nestjs-realworld-example-app icon indicating copy to clipboard operation
nestjs-realworld-example-app copied to clipboard

Published 20 hours ago • verified publisher icon lujakob

The official tests

Open sebilasse opened this issue 6 years ago • 5 comments

Hey there,

thanks for the work. I've just run this project vs the official RealWorld API Tests : I would suggest to use these for testing.

[ Currently they return one false negative ( I had corrected that in the testcode already) but there are 2 PRs for that, e.g. https://github.com/gothinkster/realworld/issues/309 ]

There are a few problems like with the relations. It looks like this bildschirmfoto 2018-12-11 um 13 28 59

I have corrected the bugs and it looks like this bildschirmfoto 2018-12-11 um 13 40 27

I'd prefer to make a fork and change it there so that you can review the code before merging anything.

sebilasse avatar Dec 12 '18 14:12 sebilasse

Awesome, thanks!

lujakob avatar Dec 13 '18 10:12 lujakob

@lujakob is this already implemented or is it still pending a PR from @sebilasse ? Please update.

sajidali avatar May 28 '19 22:05 sajidali

@sajidali There is no PR to update this.

lujakob avatar May 29 '19 12:05 lujakob

@sebilasse please submit PR with your bug fixes...

sajidali avatar May 29 '19 13:05 sajidali

@sebilasse please submit PR with your bug fixes... 🙃

SeongBrave avatar Jun 11 '19 03:06 SeongBrave