rails_admin_content_builder icon indicating copy to clipboard operation
rails_admin_content_builder copied to clipboard

Published 20 hours ago • verified publisher icon luizpicolo

increase coverage test

Open luizpicolo opened this issue 8 years ago • 4 comments

https://coveralls.io/github/luizpicolo/rails_admin_content_builder?branch=master

luizpicolo avatar Oct 22 '16 03:10 luizpicolo

@luizpicolo I can help you on this.

Do I know the reason of having :id in routes of search_content? https://github.com/luizpicolo/rails_admin_content_builder/blob/master/config/routes.rb#L2

I dont see any such use of id here.

sampatbadhe avatar Oct 22 '16 14:10 sampatbadhe

Hello @luizpicolo

I have made some changes for this https://github.com/luizpicolo/rails_admin_content_builder/compare/master...sampatbadhe:increase_test_coverage?expand=1

  • [x] removed id from the routes
  • [x] added more test cases

Can you please check and let me know if I can raise a PR for the same.

sampatbadhe avatar Oct 22 '16 15:10 sampatbadhe

Writing some tests for this, will PR later today.

jacobherrington avatar Oct 03 '17 14:10 jacobherrington

😃

luizpicolo avatar Oct 03 '17 14:10 luizpicolo