hugo-coder icon indicating copy to clipboard operation
hugo-coder copied to clipboard

H1 font size differently for pages, posts and lists

Open metbril opened this issue 3 years ago • 1 comments

For lists (including taxonomies), the font size is 3.2em, but for pages it is 4.2em. It looks better if both are the same.

Pages and posts use this:

https://github.com/luizdepra/hugo-coder/blob/af7360e89ab0220c8c1e1da2ab28cfab3410b809/assets/scss/_content.scss#L18-L27

Lists use this:

https://github.com/luizdepra/hugo-coder/blob/af7360e89ab0220c8c1e1da2ab28cfab3410b809/assets/scss/_base.scss#L72-L80

metbril avatar Oct 13 '21 20:10 metbril

I'm open to contributions with this issue.

We should use Page's values as default for headings.

luizdepra avatar Nov 02 '21 17:11 luizdepra

@luizdepra Correct me if I'm mistaken, but this looks like a simple pr to me, just overriding the value in defaults, no?

If so, I can have it pr-ed in the same day. Since I'm using the theme into my own website (still under dev) this is the least I can do. : ))

Edit: nm, looks like https://github.com/luizdepra/hugo-coder/pull/777 has fixed it already. I suggest this to be closed then. :))

AbdAllahAbdElFattah13 avatar Mar 04 '23 01:03 AbdAllahAbdElFattah13

Yup. It is already fixed. I forgot to close this issues, but thanks for pointing it to me.

luizdepra avatar Mar 05 '23 15:03 luizdepra