Luis David Rodríguez

Results 20 comments of Luis David Rodríguez

I had some weird logs while running the pre-commit check. I would like to comment on it here in order to know if I can do something to fix it....

> Hi @luisDIXMIT! I think it would be good to announce that you’re migrating this module in this issue: #919 (similar to what was done here: #726). Let me know...

He hecho rollback de mi cambio porque he matado el que había hecho @etobella sin querer, mantengo su propuesta.

Hola @pedrobaeza estoy teniendo problemas para corregir el error que me dan los tests, en local no se produce. Tras investigar me he topado con este PR que migraba el...

Hola @pedrobaeza , me he encontrado dos posibles errores que provocan el fallo de los tests. Uno viene desde el módulo l10n_es_instrastat_report. La plantilla "es_common" no existe para el modelo...

El segundo problema, como comentaba, viene del módulo l10n_es_facturae. Cuando se actualizan los impuestos con el código facturae se hace uso de la plantilla "es_common", cuando realmente los impuestos que...

> Have you checked if there's any need of XML-ID renaming of the existing taxes? No, sorry. I will check. Thanks!

Hi @pcastelovigo thanks for your work. Please follow the contribution guidelines to preserve the commit history.

> @luisDIXMIT I have checked, and when you create a vendor bill for that partner, EUR is used. Am I missing something? We did not intend to change anything in...

Good job @andrel-exo , but squash both commits into one. I think it’s more appropriate in order to make the history cleaner.