JellyPlex-Watched icon indicating copy to clipboard operation
JellyPlex-Watched copied to clipboard

Draft: Usability/logging

Open Nicba1010 opened this issue 1 year ago • 10 comments

Replaces the stock logging function with the loguru module. A work-in-progress.

Based on the updated CI branch, will rebase after merge.

Nicba1010 avatar Apr 13 '23 10:04 Nicba1010

Looks like the action fails when pushing from a PR that someone else makes. I tried changing it to actor and repository instead to see if that works so try a rebase if you can. If not i can probably just disable the push on PR

luigi311 avatar Apr 13 '23 17:04 luigi311

@luigi311 could this be it? image

Nicba1010 avatar Apr 13 '23 18:04 Nicba1010

yeah thats probably it. Ill go ahead and put a enable clause on the ghcr tag for none pr

luigi311 avatar Apr 13 '23 18:04 luigi311

And if you can fix the build step conditional so that it builds if it's a PR OR if the docker_meta outcome is skipped.

Nicba1010 avatar Apr 13 '23 18:04 Nicba1010

ok give it a try. I added in that enable check for PR for the ghcr and i also swapped the condition check for the build/build push so it checks for tags in the meta step to see if theres any repo to push to at all.

luigi311 avatar Apr 13 '23 19:04 luigi311

@luigi311 thanks :) seems to work

Nicba1010 avatar Apr 13 '23 19:04 Nicba1010

Anyways, this still isn't complete but I thought of giving multiple logging options.

  • Per run logging (store logs in log folder with timestamp)
  • Last run log
  • All runs from beginning of container creation logs

Does that sound ok? And allow the user to disable them as willing.

Nicba1010 avatar Apr 13 '23 21:04 Nicba1010

Its probably best to leave out the all runs from beginning of container creation since hopefully this container never crashes and depending on how often they have it loop and how verbose it is, it will spit out a ton of data.

luigi311 avatar Apr 13 '23 23:04 luigi311

So just keep the latest run then? Maybe disable per-run logs by default but let the user choose (and auto-compress them).

Nicba1010 avatar Apr 13 '23 23:04 Nicba1010

sure that can be an option

luigi311 avatar Apr 14 '23 00:04 luigi311