virtuality icon indicating copy to clipboard operation
virtuality copied to clipboard

Published 20 hours ago • verified publisher icon luebking

text colour in kickoff text entry

Open mattisfat opened this issue 10 years ago • 9 comments

Hi,

I love this theme, but am having an issue with the kickoff panel. The text colour when entering text is dark grey against a dark grey background. Is this an issue with this theme, or is there a tweak somewhere else that could fix it?

Thanks

mattisfat avatar May 21 '14 23:05 mattisfat

Hi, many thanks for the notice.

Get commit 87b3ce7

Unfortunately I cannot just swap the text color since i've no access to the look provided by the plasma theme :-(

luebking avatar May 22 '14 19:05 luebking

Could you add the colour swap to the "Hacks" section, so that it can be swapped by the user depending on which plasma theme they're using?

mattisfat avatar May 22 '14 19:05 mattisfat

I've also applied the commit above, and rebuilt, and it is still very hard to read - see attached image of krunner in action. Hopefully including the text colour swap "hack" is the way to go :-)

http://imgur.com/YT8ZsQV

mattisfat avatar May 22 '14 21:05 mattisfat

I could add css(-a-like) per-widget (palette) overrides, the probelm is that a) this doesn't scale ("joe user needs to know a setting to make a relevant application functional and update that with any theme change") b) this would not work with highly transparent plasma themes (where the background brightness is determined by the windows below)

Ultimately plasma themes will have to either theme anything or share information with the widget style. Given them move to QML, I assume the former, but if this is still an issue with "plasma next"

The screnshot looks like krunner, not kickoff - yesno? What theme is this in particular?

luebking avatar May 22 '14 21:05 luebking

Yes, it is krunner, but the issue seems to apply to all text input boxes in plasma. The theme is produkt, but it seems to be an issue in most of the dark themes I've tried. Also, kickoff input box does work (sorry, I was looking at krunner when I was testing), with the latest commit - but it is kinda ugly.

mattisfat avatar May 22 '14 21:05 mattisfat

The "problem" here is that krunner uses a combobox, not a lineedit ;-) -> latest commit "fixes" it.

luebking avatar May 22 '14 21:05 luebking

just pulled and built latest commit, and no change to krunner :-(

mattisfat avatar May 22 '14 21:05 mattisfat

you need commit ccccba960b1004fddf48c1b04686ad3e483cffcd - and of course to restart krunner (it's not the plasma-desktop process) Since it applies the same painting to the runner combo as to the kickoff lineedit, it kinda has to work...

luebking avatar May 22 '14 22:05 luebking

Killing krunner did it - thanks. Hopefully you can work out a more elegant solution.

Thanks again for an awesome theme.

mattisfat avatar May 22 '14 22:05 mattisfat