some suggestions

[samuaz]

Hi Thomas I have been testing virtuality and I really like the direction you are taking, I have a couple of suggestions to give you in some screenshoots, also sorry for my bad english please see the screens in the dropbox folder: https://www.dropbox.com/sh/2dbk9uzvyo2esc5/AAAHoKDknn9e0Aglgv9mqP7Aa/virtuality and if you need more explanation about the suggestions please tellme greetings

[luebking]

Please try most recent commits (b355ee7) - there should be some improvement. Thanks for the buttkick and don't worry about your English :)

[samuaz]

@luebking hi Thomas, i try the new changes and i have more suggestions but now with a small mockups https://www.dropbox.com/s/9387uoflbg0ebwf/MOCKUPS.png?m= Mockups explanation: Mockup 1: ok the changes I made are:

1. First in your new changes you enable the statusbar (icon size slider, folder count info etc) as inverted element when you enable the toolbar as inverted element, but i think should be best to enable the statusbar as inverted element when you enable the docks items as inverted element (dolphin sidebar) as you see in the mockup 1 its looks much nice, combined with the sidebar as inverted element, and the toolbar not always would be in the side because the natural position are the top (i have it in the sides because im a rare guy XD), but the dolphin sidebarbar always its in one of the 2 sides, so would be better enable the statusbar as inverted element with the dock or maybe with the two options toolbar and dock, but if it detect if the toolbar are in the sides and with that the statusbar and the toolbar and sidebar would be have that nice homogeneous/uniform look
2. also i add a small margin/padding in the top and sides of the statusbar because its looks bad very closely to the edges
3. in the sidebar i add a margin in the top and bottom of the scrollbars to have it in the middle of the sidebar, because looks very uggly have the scrollbar so big and closely to the edges (i remember i can do this with custom qss file and open dolphin with it), and also if you see i reduce the space between the scrollbar and the sidebar splitter to have the scrollbar more closely to the edge and have more space for the sidebar elements
4. in the iconview, as you see, i add space between the nice nice frames of the iconview and the sidebar, because without space having the sidebar as inverted element the new frame style are closely to the sidebar and looks uggly and you cant see the new frames style, also i move the location bar inside the iconview and move the new frame style of the iconview at the same height of the sidebar (i know maybe this can be hard due to the location bar and the iconview are to differents widgets, but for that i make the mockup 2 :) )

as you see too i add space in the right too to also make the new frame style of the iconview visible and and more space between it and the scrollbar and also add space at the right of the scrollbar and the windows border because looks uggly so closely to the windows border

and i add space too in the top and bottom of the iconview and others widgets to also make the new frame style more visible

MOCKUP 2: the mockup 2 is the same as the mockup 1 with the difference that i dont move the location bar inside the iconview because i know that can be hard without mod dolphin because are 2 differents elements, so i only add left margin in the location bar to align it with the new frame styles of the iconview.

i need to do more mockups with other combinations like having the toolbar in the side, but are most the same.

nice job thomas and thanks for this new widget style, greetings

[luebking]

1. the statusbar was actually meant as counterpart to the toolbar (top/bottom), but it still might be reasonable to invert it for config.invert.docks||config.invert.toolbars - just it should be the same everywhere (not special casing dolphin in this regard)
2. the solution here would be to simply make the scrollbars bigger and paint the slider in a padded rect, but that again would apply to more than just dolphin.
3. & 3. Explicit "fixing" of dolphin only would belong into a "hack" (or again padding statusbars in gerneral, might be worth a try)
4. i've a local patch here [1] but am not really happy with this sort of "fixing dolphin" since it shadows a more general issue (inversion ./. frames) that may easily apply in other locations -> needs a more generic solution.

Moving the locationbar around is virtually impossible (reparenting w/o dolphing knowing about this is extremely crash prone) - the way I did that in bespin was to check with the VisualFrame overlay class, but I do not intend to open that can of worms again ;-)

Thanks for your efforts. As a general request, please don't focus on making dolphin nice (though for impressive screenshots) - ideally changes should apply general improvements.

[1] diff --git a/polish.cpp b/polish.cpp index cb4b301..c06208f 100644 --- a/polish.cpp +++ b/polish.cpp @@ -502,6 +502,9 @@ Style::polish( QWidget * widget )

     // scrollarea hovering
     if ( QAbstractScrollArea *area = qobject_cast<QAbstractScrollArea*>(frame) ) {

•        if (appType == Dolphin && (config.invert.docks || config.invert.toolbars) &&
  

•            area->parentWidget() && area->parentWidget()->inherits("DolphinView"))
  

•            area->parentWidget()->setContentsMargins(F(4),F(4),F(4),F(4));
       Animator::Hover::manage(frame);
       if (QAbstractItemView _itemView = qobject_cast<QAbstractItemView_>(frame) ) {
           if (widget->inherits("KCompletionBox") && !(kStyleFeatureRequest & NoShadow))