python-gnureadline
python-gnureadline copied to clipboard
ludwigschwardt
Enable build for Python 3.12 on macOS
Replace deprecated package distutils and always use the GNU readline definitions when building on macOS.
System: MacBook Pro M1 macOS Sonoma 14.2.1 Xcode 15.1 (Apple clang version 15.0.0 (clang-1500.1.0.2.5)
- May solve: https://github.com/ludwigschwardt/python-gnureadline/issues/65
Getting this merged in (and consequently deployed to PyPI) would be a huge help for those of us using libraries like Cmd2 under the Homebrew version of Python 3.12. Until we can get working readline support, we're pretty much stuck at 3.11 :(
Huge thanks to @srmainwaring for getting this implemented!
@ludwigschwardt hey! I'm not sure if you saw this PR above, but @srmainwaring appears to have solved the Python 3.12+ issues. Would you please be able to review and merge this in to get updated builds out to PyPI? Thanks so much in advance!
Hi Chris (and Rhys and many others), thanks for the gentle prods and all your patience 😊
I've actually fixed this issue 9 months ago in 1d386554 but foolishly got sidetracked by a cool new way to activate the module 🤦🏾♂️ Instead of rolling out that fix, it is languishing in a long-running feature branch.
I prefer #undef-ing the EDITLINE macro completely, since this is python-gnureadline, not python-editline 😁
I'll split the commit out, update the Python module to the latest 3.12 one and cut a new release this week.
Thanks again for bearing with me!
That's awesome news! Thank you, @ludwigschwardt! Really appreciate your support for this project. This particular issue meant that we had started investigating moving a bunch of Cmd2 code over to a Prompt Toolkit-based REPL which, needless to say, looked to be nontrivial and semi-documented, and would have effectively amounted to a rewrite 🤣