ludwig icon indicating copy to clipboard operation
ludwig copied to clipboard

Add unit tests for image utils unet functions

Open vijayi1 opened this issue 1 year ago • 7 comments

This is a follow up to PR 3913. It adds unit tests for the image utils functions added by that PR.

vijayi1 avatar Jan 30 '24 23:01 vijayi1

Unit Test Results

  4 files  ±0    4 suites  ±0   9m 14s :stopwatch: - 2m 55s 12 tests ±0    7 :heavy_check_mark:  - 2    5 :zzz: +2  0 :x: ±0  40 runs  ±0  20 :heavy_check_mark:  - 8  20 :zzz: +8  0 :x: ±0 

Results for commit 340eb699. ± Comparison against base commit 6723a30c.

This pull request skips 2 tests.
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jan 31 '24 00:01 github-actions[bot]

The regression tests are flaky, however it looks like there's another dependency issue going on with torch nightly.

justinxzhao avatar Feb 01 '24 17:02 justinxzhao

@arnavgarg1 sure. can you please confirm if the following steps are correct to rebase a PR and make additional changes (if needed),

To rebase my branch: git fetch upstream git rebase upstream/master

To make further code changes: git add . git commit git push -u origin unet-image-utils-tests

vijayi1 avatar Feb 05 '24 21:02 vijayi1

@vijayi1 I think that mostly looks correct! I would change the ordering of the steps to be this instead:

  1. git fetch upstream
  2. git checkout unet-image-utils-tests (you want to make sure you're on your branch)
  3. git rebase upstream/master (rebase onto your branch)

Followed by: git add . git commit -m git push -u origin unet-image-utils-tests

arnavgarg1 avatar Feb 05 '24 21:02 arnavgarg1

@arnavgarg1, I followed those steps exactly and got the following error during push,

(dl_venv) [vijayi@sparky01 ludwig]$ git push -u origin unet-image-utils-tests To github.com:vijayi1/ludwig.git ! [rejected] unet-image-utils-tests -> unet-image-utils-tests (non-fast-forward) error: failed to push some refs to 'github.com:vijayi1/ludwig.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details. (dl_venv) [vijayi@sparky01 ludwig]$

vijayi1 avatar Feb 06 '24 19:02 vijayi1

@vijayi1 I see. Okay, if you abort the rebase, another option is to just pull the latest master and merge it into your branch - it should achieve roughly the same effect?

arnavgarg1 avatar Feb 06 '24 19:02 arnavgarg1

@arnavgarg1, merge completed and I added a few description changes for the docs. the utils tests passed.

vijayi1 avatar Feb 06 '24 20:02 vijayi1