ludwig icon indicating copy to clipboard operation
ludwig copied to clipboard

Reduce memory requirements for TabTransformerCombiner for situation of no categorical input features

Open jimthompson5802 opened this issue 2 years ago • 1 comments

Currently the constructor for TabTransformerCombiner always allocates a transformer stack. However, the transformer stack is only used if categorical input features are in the training data. If there are no categorical features, the algorithm does not use the transformer stack. In addition to allocating unneeded memory, this complicates the unit test for this combiner.

Proposed change is to refactor the constructor to allocate the transformer stack only if categorical features are present in the input features.

jimthompson5802 avatar Aug 23 '22 09:08 jimthompson5802

Piero and Jim already chatted about this. @jimthompson5802 what's the next step for this?

dalianaliu avatar Sep 19 '22 16:09 dalianaliu

Hi @jimthompson5802 looks like you have chatted with Piero. Would you like to resolve this or leave it open for next steps?

dalianaliu avatar Sep 21 '22 16:09 dalianaliu

@dalianaliu Once I'm done with the torchvision integraiton work, I can take a stab at this.

jimthompson5802 avatar Sep 23 '22 17:09 jimthompson5802