ludwig icon indicating copy to clipboard operation
ludwig copied to clipboard

TMP folder on a different drive breaks

Open fire opened this issue 2 years ago • 5 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

Store root on one file system and home in a different filesystem.

/home/username/.local/lib/python3.10/site-packages/ludwig/utils/checkpoint_utils.py

Please provide code, yaml config file and a sample of data in order to entirely reproduce the issue. Issues that are not reproducible will be ignored.

Expected behavior

Not error out with errno-18-cross-device-link

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: Linux fedora 5.17.5-300.fc36.x86_64 #1 SMP PREEMPT Thu Apr 28 15:51:30 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • Version 36
  • Python version 3
  • Ludwig version 0.5.4

Additional context https://stackoverflow.com/questions/11578443/trigger-io-errno-18-cross-device-link

Try

Changing os.replace to shutil.move(tmp_path, save_path)

fire avatar Jul 20 '22 23:07 fire

I merged this PR about 2 weeks ago, because I may have encountered the same issue:

https://github.com/ludwig-ai/ludwig/pull/2225

@fire Could you try the same run using the latest ludwig master and see if it is resolved?

dantreiman avatar Jul 21 '22 19:07 dantreiman

Is there docs on how to do that?

fire avatar Jul 21 '22 19:07 fire

You can run python -m pip install git+https://github.com/ludwig-ai/ludwig.git (may need to uninstall and re-install or upgrade) and here are more details on hot to work with branches and specific commits: https://adamj.eu/tech/2019/03/11/pip-install-from-a-git-repository/

w4nderlust avatar Jul 21 '22 20:07 w4nderlust

Will wait for a new minor release then.

fire avatar Jul 22 '22 11:07 fire

Hey @fire, this should be fixed now in v0.5.5. Please try it out and let us know how it goes!

tgaddair avatar Aug 02 '22 21:08 tgaddair

We just released v0.6. I'm closing this, and please reopen if you have questions.

dalianaliu avatar Sep 29 '22 16:09 dalianaliu