fooyin
fooyin copied to clipboard
FLAC subset tests don't work completely
Describe the bug The FLAC conformance subset files from here: https://github.com/ietf-wg-cellar/flac-test-files/tree/main/subset
Fail to decode properly. A resampler with track start/end padding with LPC (and subsequently removing padding from resampler output), or a resampler which already makes this sort of guarantee for gapless decoding, may be needed for the mixed sample rate cases to play gaplessly. (Though this is an edge case.)
Sample 22, 12 bits per sample, crashes the player. I can supply a backtrace if needed. Sample 45, no total number of samples set, fails to decode, because presumably the lack of a total sample count is treated as zero length?
All the rest of the samples decode fine, though the embedded CUE sheet samples don't display their CUE sheets in the playlist. They do use the FLAC binary cue system instead of embedded "CUESHEET" tags with textual CUE sheets, though.
To Reproduce
- Download the above linked test file set.
- Play them all in sequence.
Expected behaviour All files should play sequentially, with minimal fuss. Maybe a resampler option to make the mixed sample rate files play seamlessly. And maybe a downmixer to handle the channel count changes among the surround files.
System:
- OS: Arch Linux
- fooyin version: fooyin-git r2523.cdcb6459-1
Additional context This is probably an infamous test file set, since they're all such weird quirks of the FLAC format subset.