GuzzleBundle icon indicating copy to clipboard operation
GuzzleBundle copied to clipboard

Published 20 hours ago • verified publisher icon ludofleury

Silex provider

Open mtotheikle opened this issue 11 years ago • 9 comments

This pull requests allows integration to the guzzle data collector with Silex. Documentation on usage is slim right now and no tests have been done.

One thing that still needs to be done and needs discussion is how to load the font files that are needed since we can not use the "asset" filter.

mtotheikle avatar Nov 06 '13 21:11 mtotheikle

I'm reviewing this asap, thanks a lot.

ludofleury avatar Nov 08 '13 01:11 ludofleury

Sounds good. Let me know your thoughts on loading of the fonts since we have to handle it a little differently with Silex based applications. It will probably require some configuration I'm thinking.

mtotheikle avatar Nov 14 '13 23:11 mtotheikle

Actually I never used the web profiler from Symfony on Silex. I have to try first. But i guess i understand the prob the "bundle trivial feature" aren't provided by Silex, so the embedded assets aren't "magically" dumped right ? On Nov 15, 2013 12:54 AM, "Michael Williams" [email protected] wrote:

Sounds good. Let me know your thoughts on loading of the fonts since we have to handle it a little differently with Silex based applications. It will probably require some configuration I'm thinking.

— Reply to this email directly or view it on GitHubhttps://github.com/ludofleury/GuzzleBundle/pull/16#issuecomment-28535535 .

ludofleury avatar Nov 15 '13 00:11 ludofleury

Correct. This means that we don't know where these assets will live on the web server

mtotheikle avatar Nov 15 '13 01:11 mtotheikle

Hey, so my question is: is this a common practice to include silex provider in a bundle ? I have a solution which is actually provide a post composer script to dump the assets in a configured path... But it would be extra hackish and since there is no hard convention in silex, it would require an user input.

The other solution is to actually separate this provider in another repo with a composer dependecy to this bundle. Then we could add a script/command to dump the assets.

ludofleury avatar Nov 30 '13 16:11 ludofleury

I'm not sure what the best practice is. As long as the other repo is referenced within this one so that developers easily see it exist I'm sure it would be fine to live on it's own.

mtotheikle avatar Dec 10 '13 16:12 mtotheikle

Ok, let's do this. I'll reference it in the readme :+1:

ludofleury avatar Dec 24 '13 09:12 ludofleury

Be aware that this bundle could be merged into this one: https://github.com/misd-service-development/guzzle-bundle/pull/29

ludofleury avatar Dec 25 '13 06:12 ludofleury

Great to see the merging of the bundles happening!

mtotheikle avatar Jan 02 '14 00:01 mtotheikle