integration_blueprint icon indicating copy to clipboard operation
integration_blueprint copied to clipboard

Remove Rust from devcontainer

Open felipecrs opened this issue 2 years ago • 3 comments

It is not necessary for ruff, which gets installed with pip.

This makes the devcontainer build faster.

felipecrs avatar Oct 12 '23 18:10 felipecrs

It is not necessary for ruff

That argument would make sense if this repository was for ruff. That is not the case. Is there no longer anything in HA (including its requirements like cryptography) that requires rust?

ludeeus avatar Oct 12 '23 20:10 ludeeus

I have no clue. I was just wondering why would anyone need Rust in their devcontainers.

Also, if just a few users need it, maybe they can add it themselves.

For example, I need ffmpeg for the ffmpeg integration. I should probably add it myself to the devcontainer rather than pushing it to everyone.

felipecrs avatar Oct 12 '23 20:10 felipecrs

When it was added, it was required for HA to start correctly.

ludeeus avatar Oct 12 '23 20:10 ludeeus

Features are currently broken on rootless podman installs:

https://github.com/devcontainers/cli/issues/548

Bumped into this while poking around using my Steam Deck in desktop mode. I was able to boot Home Assistant 2024.5.2 without the Rust feature.

Sharpie avatar May 11 '24 12:05 Sharpie

The 2023.8.0 version currently pinned in requirements.txt also runs without the Rust feature enabled.

Sharpie avatar May 11 '24 15:05 Sharpie