luckytyphlosion

Fix up save nomenclature

2

It makes no sense. There are four structs: SaveArrayHeader, SaveArrayFooter, SaveChunkHeader, SaveChunkFooter. SaveChunkHeader isn't even defined in the same place as SaveChunkFooter. ```c static void CreateChunkFooter(SaveData *saveData, void *data, int...

Decide consensus on SDK filenames

1

I didn't realize this was a contention point, but apparently it is. Don't waste time thinking about this issue, I just wanted to get these thoughts down while they were...

All local variables, function parameters, struct fields should be camelCase.

11

Useful grep to find instances: `grep -Pwr --include="*.c" --include="*.h" "[a-z_]+_[a-z_]+[,;\)]" --exclude-dir="tools" --exclude-dir="sub" --exclude-dir="lib" --exclude-dir=".github" --exclude-dir="files"` ## Do not apply this logic to Nintendo Libraries. ### Local variable example **Good:** ```c...

Decide consensus on styling for recursive/"references each other" structs AND styling for unions.

10

### 5. There is no consensus for defining recursive structs. When defining a recursive struct, the struct must be declared and defined. Below are the options for declaring the struct....

Fix all struct names to be consistent with the agreed upon style guide.

1

## There are still some style directions relating to structs which have no consensus. Those can be found at issue #212 ### 1. All structs must have a corresponding typedef....

Decide consensus of naming "cardinality" constants.

32

Cardinality is just number of elements for a set. So it could refer to the total length of an array, the number of values an enum could have, and other...

Replace all instances of idx with index.

1

See the consensus discussion at #218 TODO write up a grep.

Replace all instances of `no` as number to `num` or something equivalent

1

See the previous consensus discussion at #217 TODO write up a grep.

Style enums properly.

3

# There is no consensus whether enums are enums or typedefs. ## Case 1: enums are enums, not typedefs ### Do not typedef enums **Good:** ```c enum RTC_TimeOfDay { RTC_TIMEOFDAY_MORN...

Determine style guide for function naming

15

Examples to kick off discussion. ### Example 1  ### Example 2  ### Example 3  ### Example 4  ### Example 5