luckytyphlosion

Results 55 comments of luckytyphlosion

_MAX is good, I didn't think of that one

> the spirit of pikalax — Today at 8:15 PM > `NUM_MULCH_KINDS` > solved

I think MAX is the best. What makes stuff like `total`, `num`, and `count` ambiguous is that they can refer to both a noun and adjective. But `max` is much...

> length imo, considering stuff like player name > > sounds a lot better being PLAYER_NAME_LENGTH etc Fyi, this can be either LEN or LENGTH.

Fyi, we should probably clarify between using Num and Total. Total should be used when aggregating together a quantity-like value, so we say `GetTotalMulchQuantity`, not `GetNumMulchQuantity` Num should be used...

Get is another issue entirely that I didn't want to open just yet because of how intricate it is.

> Gen 3 had the `_COUNT` suffix, so maybe that could work here? Count runs into issues as you can use it to refer to both a calculated value and...

This might be a problem though. AsparagusEduardo mentioned that in the gen 3 repos, MAX refers to a hard limit of the maximum cardinality a set could have, while NUM...

One possibility: say `MAX_APRICORN_TREES` and `MAX_SAVE_APRICORN_TREES`

We could also say `MAX` for hardware limit, `NUM` for defined limit, and `count` for quantity. So when standardizing the below function: ```c BOOL Save_NumModifiedPCBoxesIsTooMany(SaveData *saveData) { return Save_CalcNumModifiedPCBoxes(saveData) >=...