KeePass-Favicon-Downloader
KeePass-Favicon-Downloader copied to clipboard
Remove Download Failure Dialog Box?
When the plugin fails to retrieve a favicon—network error, website error, or if there simply isn't one—it supplies a wordy dialog with an OK button to explain the failure
It seems to me that this is quite unnecessary. The process itself already takes over the UI stream. A simple self-closing popup or perhaps sentence in the status bar (if possible) would be more than adequate. No one expects every website to have a favicon, and this dialog belabors the point a little too much, I think.
No one expects every website to have a favicon
I'm not sure I'd go quite that far but totally agree that there are a majority of cases where the UI surrounding failure modes could be better and I would expect our options for UI controls are better now than 8 years ago.
I think the current implementation does the job though so I won't personally be prioritising work to improve this - although pull requests are welcome.
When this is removed (what I think is okay), then logging functionality should be introduced instead.