KeePass-Favicon-Downloader icon indicating copy to clipboard operation
KeePass-Favicon-Downloader copied to clipboard

Remove Download Failure Dialog Box?

Open photonometric opened this issue 7 years ago • 2 comments

When the plugin fails to retrieve a favicon—network error, website error, or if there simply isn't one—it supplies a wordy dialog with an OK button to explain the failure

keepass favicon error dialog

It seems to me that this is quite unnecessary. The process itself already takes over the UI stream. A simple self-closing popup or perhaps sentence in the status bar (if possible) would be more than adequate. No one expects every website to have a favicon, and this dialog belabors the point a little too much, I think.

photonometric avatar Sep 22 '16 09:09 photonometric

No one expects every website to have a favicon

I'm not sure I'd go quite that far but totally agree that there are a majority of cases where the UI surrounding failure modes could be better and I would expect our options for UI controls are better now than 8 years ago.

I think the current implementation does the job though so I won't personally be prioritising work to improve this - although pull requests are welcome.

luckyrat avatar Apr 29 '17 11:04 luckyrat

When this is removed (what I think is okay), then logging functionality should be introduced instead.

darkdragon-001 avatar Apr 27 '20 01:04 darkdragon-001