avram icon indicating copy to clipboard operation
avram copied to clipboard

Postinstall scripts do not ignore crystal version

Open akadusei opened this issue 4 years ago • 0 comments

https://github.com/luckyframework/avram/blob/b3feadcc93d48ec1ee24c4a33f4eeaf5b089ee20/script/precompile_tasks#L9

I'm running shards install --ignore-crystal-version which works OK, except for when it gets to postinstall (defined in shard.yml). This runs shards build and fails because of an apparent Crystal version resolution failure.

I suggest --ignore-crystal-version be passed to any shards call in such scripts. This should leave the developer to decide in their own shards install call whether or not to ignore Crystal version. If the developer does not supply this argument and Crystal version resolution fails, postinstall won't run, so we're still covered.

Also applies to Lucky: https://github.com/luckyframework/lucky/blob/e2b15e75d522ecd82976945d83f991e1f967c6c3/script/precompile_tasks#L6, and probably more repos.

akadusei avatar Mar 04 '21 15:03 akadusei