lucko
Spark client commands parsing is incorrect in 1.18.2 - missing slash
Description
In the run method there are missing slashed before sparkc and sparkclient commands
https://github.com/lucko/spark/blob/49f2de970d0a80261a84812c42a60eab43982032/spark-forge/src/main/java/me/lucko/spark/forge/plugin/ForgeClientSparkPlugin.java#L87
I have fixed this with mixin and confirmed that it's working, but I can't build the 1.18.2 branch to make a PR because there are some errors with the bytesocks library (probably version issue)
@Mixin(value = ForgeClientSparkPlugin.class, remap = false)
public class MixinForgeClientSparkPlugin {
@ModifyArg(method = "run", at = @At(value = "INVOKE", target = "Lme/lucko/spark/forge/plugin/ForgeClientSparkPlugin;processArgs(Lcom/mojang/brigadier/context/CommandContext;Z[Ljava/lang/String;)[Ljava/lang/String;"))
private String[] fixClientCommands(String[] original) {
return new String[]{"/sparkc", "/sparkclient"};
}
}
anybody that is looking into temp fix until it is fixed in spark itself can get this mod that adds those slashes back radimous/spark1.18clientfix/releases/tag/v1.0
Reproduction Steps
run any command on 1.10.38 (Forge 1.18.2) starting with /sparkc and see that suggestions work, but the command itself doesn't
Expected Behaviour
/sparkc commands should work
Platform Information
- Minecraft Version: 1.18.2
- Platform Type: client
- Platform Brand: forge
- Platform Version: Forge 40.2.13
Spark Version
v1.10.38
Logs and Configs
No response
Extra Details
No response
if 1.18.2 is not supported anymore, I'll just push the fix mod to curse even if I don't think that the last version built for mc version should be broken I just want profileable client
