Use Bukkit#getName() for server name

[powercasgamer]

Paper (1.20.6+) Before:

Paper After:

Spigot:

Maybe need to check if the version contains Spigot then use 'Spigot' as the server name? But imho Spigot..

[EterNityCH]

This would fix the existing issue on 1.21. LGTM

[lucko]

Unfortunately the server type string is used to determine which mappings to use -- https://github.com/lucko/spark-mappings/blob/master/dist/mappings.json#L3

Instead could we incorporate the server brand into the version string?

[powercasgamer]

Unfortunately the server type string is used to determine which mappings to use -- lucko/spark-mappings@master/dist/mappings.json#L3

Instead could we incorporate the server brand into the version string?

Something like this? Paper:

Spigot:

Purpur:

~~I'm not actually sure how it'll look on older versions. Perhaps a version check? Or not bother making it look good on <1.20.5?~~ Paper 1.19.4:

~~For Spigot we could also check if the string contains "Spigot" and then just not add it or something.~~

[lucko]

Decided to just add a brand field separate from name so we can show it nicely :)

https://github.com/lucko/spark-viewer/commit/568817f36076bbf596e2c782ba667aece4bdb299

Thank you for the PR!