minecraft-command-permissions-fabric icon indicating copy to clipboard operation
minecraft-command-permissions-fabric copied to clipboard

[Request] Add "minecraft.login.bypass-player-limit" permission node

Open elhertz opened this issue 4 years ago • 6 comments

The readme say that it's not "implemented". Are you planning on doing so? I really need to give that permission to my nitro boosters. I couldn't find anything similar on the internet. Thanks.

elhertz avatar Oct 10 '21 05:10 elhertz

For the time being, I'll only add features that are requested like you just did. I will try to implement the permission.

TjeuKayim avatar Oct 10 '21 06:10 TjeuKayim

Thank you. You're a life saver!

elhertz avatar Oct 10 '21 06:10 elhertz

Can you please help testing this version? minecraft-command-permissions-TEST-login-bypass.zip

TjeuKayim avatar Oct 10 '21 07:10 TjeuKayim

example example2

elhertz avatar Oct 10 '21 09:10 elhertz

Sorry, the version I posted doesn't work because the players are not yet loaded by LuckPerms at the point in the login phase were the player limit is checked. Unfortunately, fabric-permissions-api doesn't support getting permissions for such 'offline' users. With the full LuckPerms API, it is possible but not trivial to implement in a way that doesn't make login attempts laggy. Also, in order to not limit the compatibility of this mod, the dependency on LuckPerms API should be optional. So, it seems easier to create a separate mod for implementing minecraft.login.bypass-player-limit.

TjeuKayim avatar Oct 10 '21 10:10 TjeuKayim

Oooh I think I get it. We are limited by the fabric-permissions-api. Creating a separate module makes sense then. Not everyone uses LuckPerms. Thanks for the clarification. If it's not too much work I hope you can make a separate mod for this, but if you can't then it's ok, I think that it'd be just a waste of your time making a mod just for me haha Thanks!

elhertz avatar Oct 10 '21 21:10 elhertz