TheForceEngine icon indicating copy to clipboard operation
TheForceEngine copied to clipboard

More bugfixes

Open mlauss2 opened this issue 1 year ago • 1 comments

More bug/warningfixes and ipdates to get it building on Apple/Clang toolchains. based on feedback in #90

  • QUAD_MAX is a reserved symbol in xnu's "limits.h" file
  • clang doesn't like passing std::string to logWrite()
  • disable clang's excessive warnings about unhandled enum values in switch() statements
  • fix lots of clang warnings about assignments inside while() without extra brackets.
  • adjust the min/max/clamp(size_t) functions to u64, since size_t == u32 on 32bit targets
  • LINE_MAX is another reserved symbol on xnu/apple.
  • change the size_t in memoryRegion, which is written out to savegames, to an u64, to keep apple toolchain happy and the savegame format independent of the target architecture size.

mlauss2 avatar Jul 08 '24 08:07 mlauss2

Definitely get much further with this PR on Mac, sent a minor PR to your original branch for CMakeLists to at least get the build going on Mac

jodaco avatar Jul 08 '24 19:07 jodaco