silk icon indicating copy to clipboard operation
silk copied to clipboard

JSHint changes so tests pass out of the box

Open yeeplusplus opened this issue 9 years ago • 1 comments

On the latest commit (dde5a74), grunt jshint:source fails.

Some of these failures are violations of rules that have been deprecated in favor of using JSCS / ESLint. In order to ease the developer on-boarding process, I think it makes sense to relax these rules, where appropriate, so that the project does not spew a bunch of errors the first time the tests are run. This can be done by upgrading grunt-contrib-jshint to 1.0.0, which removes the deprecated JSHint options.

Other failures are straightforward (== instead of ===, missing semicolons, etc.).

I'm happy to make a PR. Is this type of change desired by the community here?

yeeplusplus avatar Apr 27 '16 19:04 yeeplusplus

@yeeplusplus A PR is most welcome.

You could also use the -f flag to ignore the JSHint warnings for now. :-)

Thanks for reporting the issue.

arijitdasgupta avatar Apr 29 '16 11:04 arijitdasgupta