ex-portmidi icon indicating copy to clipboard operation
ex-portmidi copied to clipboard
verified publisher icon lucidstack

Don't send empty messages

Open patmaddox opened this issue 5 years ago • 3 comments

Fixes #16

patmaddox avatar Dec 13 '20 21:12 patmaddox

It is easy enough for the client to look for [] events and ignore them - I thought it made more sense for the library to not send empty events at all though. What do you think?

patmaddox avatar Dec 13 '20 21:12 patmaddox

Turns out this makes it less reliable - messages can stop getting sent after a while. I still think it probably doesn't make sense to send empty messages (I'm seeing thousands of empty messages at a time sometimes). I'm just not sure how to do that...

patmaddox avatar Dec 13 '20 21:12 patmaddox

@patmaddox the "empty messages" problem seems to be fixed by #15. I will incorporate it into my own fork at https://github.com/thbar/ex-portmidi.

thbar avatar May 09 '21 17:05 thbar