cumulus icon indicating copy to clipboard operation
cumulus copied to clipboard

RDS module, fixes #150

Open mcrossen opened this issue 9 years ago • 5 comments

db subnet groups will need to be managed differently (like how ec2 instances are managed different from ebs). For now, db subnet groups can be managed in the aws console. Apart from that everything seems to be working.

mcrossen avatar Aug 05 '16 19:08 mcrossen

You should add some tests like I did in the SQS module. That would be super rad. Also... add documentation for it on the gh-pages branch. Man, I'm so glad I can make your life terrible even after leaving.

msiebert avatar Aug 08 '16 22:08 msiebert

@msiebert jerk! ok. good idea. i've already made the documentation, but wasn't going to make a pull request for it until this is merged. I guess I can at least push it.

mcrossen avatar Aug 09 '16 15:08 mcrossen

uhh. wow. all I wanted was to push a few testing-related commits. seems like it pushed a lot more. well.... uhh.... oops I'm going to fix that and force push it all out.

mcrossen avatar Aug 16 '16 21:08 mcrossen

dude, @mcrossen, I'm loving the fact that there are tests here! Way to go!

msiebert avatar Aug 19 '16 21:08 msiebert

yea. me too! so this pull request is ready to be reviewed again.

mcrossen avatar Aug 19 '16 21:08 mcrossen