egnn-pytorch icon indicating copy to clipboard operation
egnn-pytorch copied to clipboard

Wrong edge_index size hint in class EGNN_Sparse of pyg version

Open Layne-Huang opened this issue 3 years ago • 2 comments

Hi, I found there may be a little mistake. In the input hint of class EGNN_Sparse of pyg version, the size of edge_index is (n_edges, 2). However, it should be (2, n_edges). Otherwise, the distance calculation will be not correct. """ Inputs: * x: (n_points, d) where d is pos_dims + feat_dims * edge_index: (n_edges, 2) * edge_attr: tensor (n_edges, n_feats) excluding basic distance feats. * batch: (n_points,) long tensor. specifies xloud belonging for each point * angle_data: list of tensors (levels, n_edges_i, n_length_path) long tensor. * size: None """

Layne-Huang avatar May 13 '22 12:05 Layne-Huang

oh oops @hypnopump ^ just so you know!

lucidrains avatar May 19 '22 15:05 lucidrains

@Layne-Huang should be corrected!

lucidrains avatar May 23 '22 17:05 lucidrains