deep-daze icon indicating copy to clipboard operation
deep-daze copied to clipboard

Doesn't save any images to disk

Open n00mkrad opened this issue 3 years ago • 5 comments

The current version (pip) doesn't save any images, no matter which save_every value.

Tested locally (Win 10) and on the simplified Colab notebook.

n00mkrad avatar Feb 27 '21 19:02 n00mkrad

@n00mkrad ohh, for some reason it is hidden behind a CLI flag now --save-progress, but i defaulted it to true in the latest version! https://github.com/lucidrains/deep-daze/releases/tag/0.6.3

lucidrains avatar Feb 27 '21 19:02 lucidrains

Nice I think that was my bad. I always use save-progress.

afiaka87 avatar Feb 27 '21 20:02 afiaka87

I mean the CLI can't display images, I don't see the point of it being disabled by default lol

n00mkrad avatar Feb 27 '21 20:02 n00mkrad

@n00mkrad I think @afiaka87 wanted to only save it at the very end

lucidrains avatar Feb 27 '21 20:02 lucidrains

Yeah I believe that's how it turned out. Ultimately just not testing with the CLI (I'm using the notebook) as I dont have a great GPU locally and not testing all the parameters before shipping. My bad.

afiaka87 avatar Feb 27 '21 21:02 afiaka87