lucide
lucide copied to clipboard
lucide-icons
Add Magento 2 Hyva package to docs
I love what you all doing with this Icon pack, I made a Magento 2 module for Hyva Themes that uses Lucide -> https://github.com/Siteation/magento2-hyva-icons-lucide
This PR will add the icon to homepage header, and adds a page to to the docs.
I am not sure how to add a section to the package page, not clear how this is handled, I suspect this done trough each package.json in the packages folder, is there an easy way for 3de part modules to be added to this list?
But anyway that's is something for later to add.
Sorry for the late reply. I appreciate the work, nice package. I'm not sure if we need to place "not official lucide" packages on the homepage to avoid confusion among users. I now laravel there as wel but I think we should move that one as wel. I think it is better if we make a "third party packages" section on the packages page.
@ericfennis any chance this can be added now and moved later? I would love to tweet and do some more things about this addition to Hyva, as alternative icon pack.
Also I think the icons on the homepage are not confusing, the docs and the packages are the best place to split the 3de party option from the core options.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@GrimLink Sorry for the late reply and lack of help with this implementation. It's a bit on a low prio right now.
If you like to add it you can, we want to create a third-party section on the packages page on the site. We can create a json file for it to specify the package name and etc. We already have an json file for the first party packages, so we can base it on that one.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.
@GrimLink I've added https://github.com/lucide-icons/lucide/blob/main/site/src/data/packageData.thirdParty.json, a data list for third-party packages. It will show up on https://lucide.dev/packages.
@ericfennis super! I have not got a chance to to take a look to improve the 3de party implementation. So this great.
I will create a new PR with with only the change to the packageData.thirdParty.json 😉