lucide icon indicating copy to clipboard operation
lucide copied to clipboard

feat: add 'a' plus/minus icons

Open mittalyashu opened this issue 2 years ago • 14 comments

Can be used for increase/decreasing font size.

Preview
CleanShot 2022-03-28 at 19 33 50@2x

mittalyashu avatar Mar 28 '22 13:03 mittalyashu

it looks kinda weird to me...
also in which use case would this be useful?

ghost avatar Mar 28 '22 21:03 ghost

In which use case would this be useful?

If we want to add a button for increase or decreasing the font size.

mittalyashu avatar Mar 29 '22 05:03 mittalyashu

Oh okay
your opinion on this @ericfennis ?

ghost avatar Mar 30 '22 17:03 ghost

I was thinking to make the "A" alphabet more smaller but we also haven’t setup any guidelines on english alphabets either.

mittalyashu avatar Apr 03 '22 10:04 mittalyashu

I think the plus and the minus look to close to the A. Maybe move the A a little bit to the left, creates more room for the minus and the plus

ericfennis avatar Apr 03 '22 16:04 ericfennis

I think the plus and the minus look to close to the A. Maybe move the A a little bit to the left, creates more room for the minus and the plus

@ericfennis I also agree, but then, the "A" alphabet would not be vertically centred. The only I can think of is to shrink the size bit more.

mittalyashu avatar Apr 04 '22 05:04 mittalyashu

I think the icon should be vertically centered but horizontally it is not really that problem. See for example the user-plus icon.

ericfennis avatar Apr 11 '22 18:04 ericfennis

maybe you should narrow the A

ghost avatar Apr 16 '22 15:04 ghost

I personally think that an arrow would be more fitting because you increase the font size rather than adding or subtracting a font size.

In my head plus or minus is for deleting or adding

Take a look at open office writer or microsoft word

SnoutBug avatar May 03 '22 17:05 SnoutBug

@mittalyashu Any updates on this?

ericfennis avatar May 07 '22 14:05 ericfennis

Adding space between A and +/-.

CleanShot 2022-05-15 at 12 59 13@2x

This is, adding space + shrink A alphabet.

CleanShot 2022-05-15 at 12 59 43@2x

Just shrinking the A alphabet

CleanShot 2022-05-15 at 13 00 38@2x

mittalyashu avatar May 15 '22 07:05 mittalyashu

@mittalyashu Nice work, I think it is better to have the A on the same position in both icons. I think I like the first one the most.

ericfennis avatar May 22 '22 09:05 ericfennis

any progress on this @mittalyashu ?

ericfennis avatar Jul 11 '22 18:07 ericfennis

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 11 '22 03:08 github-actions[bot]

Closing this due to inactivity

ericfennis avatar Oct 18 '22 14:10 ericfennis