lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Offer filled icons for flutter / non-web platforms

Open prateekmedia opened this issue 3 years ago • 10 comments

Icon Request

  • Icon name's: Thumbs up and down (other filled icons to consider => heart, star)
  • Use case: Currently lucide icons only have outlined icons even for some common filled icons too like thumbs up, but if someone wants to fill them in any case other then web like in flutter then they are bound to not been able to do so. It would be great if the flutter/ttf maintainer give some common filled icons to use.
  • Screenshots of similar icons: Below is the screen of youtube's like/dislike icons where thumbs up is filled and thumbs down is not Screenshot from 2021-09-23 12-57-48

prateekmedia avatar Sep 23 '21 07:09 prateekmedia

Also, I know this might be done by using filled property of css in the web but I am using it on flutter and currently it doesn't have that feature and I am forced to use the outlined one.

prateekmedia avatar Sep 23 '21 07:09 prateekmedia

I understand the need here, but I think this doesn't go with our design guidelines.

moeenio avatar Sep 25 '21 11:09 moeenio

@locness3 I know this idea was discarded in feather icons due to the fact that we can fill the icons using css in web.

But I and many others are using this as a flutter package, which uses a ttf font, and hence no one can directly fill it. It would be great if the maintainer of that lucide_icons or the .ttf font gives us support of some common filled icons like thumbs up/down or other one's like heart and star.

prateekmedia avatar Sep 25 '21 12:09 prateekmedia

That is to consider.

moeenio avatar Sep 26 '21 06:09 moeenio

@ericfennis what do you think?

moeenio avatar Dec 26 '21 13:12 moeenio

@prateekmedia @locness3 I understand why you want this, and I agree would be nice to add these type of icons. But it is a whole new icon set what we then should create. We can't just add filled icons to the set. The project is not ready for this. Especially the build flows.

ericfennis avatar Dec 26 '21 13:12 ericfennis

Totally just playing around here, but here's a small proof of concept of how I think multiple icon styles could be feasible while not having to create a filled/duotone version manually for every single icon using CSS classes: https://jsfiddle.net/cgd9a3h0/1/

karsa-mistmere avatar May 10 '22 10:05 karsa-mistmere

@karsa-mistmere That was possible but please read the title of the issue, this is regarding flutter/non-web platform where we can't just use css rules.

prateekmedia avatar May 10 '22 11:05 prateekmedia

I think it should still be feasible. Building separate styles should simply boil down to the build flow manipulating elements based on classes / custom attributes.

karsa-mistmere avatar May 10 '22 11:05 karsa-mistmere

imo this just boils down to creating separate icons for certain togglable buttons. Opening [Icon Request]

frozencap avatar Oct 18 '22 03:10 frozencap

Filled/fillable icons are definitely something we might explore in the future, but we have a lot on our plates as it is, I'll close this for now and discussions can continue in #458.

karsa-mistmere avatar Apr 27 '23 14:04 karsa-mistmere