lucide icon indicating copy to clipboard operation
lucide copied to clipboard

feat(icons): Add `ethernet-port` and `wired-connection` icons

Open ericfennis opened this issue 9 months ago • 5 comments

Closes #1816

What is the purpose of this pull request?

  • [x] New Icon
  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other:

Icon use case

To indicate a network connection in a router, network switch, or similar interfaces. Can also be used as a system icon, next to the existing system icons (wifi, Bluetooth, battery and audio etc)

Alternative icon designs

See #1816

Icon Design Checklist

Concept

  • [x] I have provided valid use cases for each icon.
  • [x] I have not added any a brand or logo icon.
  • [x] I have not used any hate symbols.
  • [x] I have not included any religious or political imagery.

Author, credits & license

  • [x] The icons are solely my own creation.
  • [x] The icons were originally created in #<issueNumber> by @<githubUser>
  • [x] I've based them on the following Lucide icons:
  • [x] I've based them on the following design:

Naming

  • x ] I've read and followed the naming conventions
  • [x] I've named icons by what they are rather than their use case.
  • [x] I've provided meta JSON files in icons/[iconName].json.

Design

  • [x] I've read and followed the icon design guidelines
  • [x] I've made sure that the icons look sharp on low DPI displays.
  • [x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • [x] I've made sure that the icons are visually centered.
  • [x] I've correctly optimized all icons to three points of precision.

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

ericfennis avatar May 03 '24 08:05 ericfennis

Added or changed icons

icons/chevrons-left-right-ellipsis.svgicons/ethernet-port.svg

Preview cohesion icons/square-stack.svgicons/square-user-round.svg
icons/chevrons-left-right-ellipsis.svgicons/ethernet-port.svg
icons/hard-hat.svgicons/layout-panel-left.svg
Preview stroke widths icons/chevrons-left-right-ellipsis.svgicons/ethernet-port.svg
icons/chevrons-left-right-ellipsis.svgicons/ethernet-port.svg
icons/chevrons-left-right-ellipsis.svgicons/ethernet-port.svg
DPI Preview (24px) icons/chevrons-left-right-ellipsis.svg icons/ethernet-port.svg
Icon X-rays icons/chevrons-left-right-ellipsis.svg icons/ethernet-port.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const ChevronsLeftRightEllipsisIcon = createLucideIcon('ChevronsLeftRightEllipsis', [
  ["path",{"d":"m18 8 4 4-4 4"}],
  ["path",{"d":"m6 8-4 4 4 4"}],
  ["path",{"d":"M8 12h.01"}],
  ["path",{"d":"M12 12h.01"}],
  ["path",{"d":"M16 12h.01"}]
])

const EthernetPortIcon = createLucideIcon('EthernetPort', [
  ["path",{"d":"m15 20 3-3h2a2 2 0 0 0 2-2V6a2 2 0 0 0-2-2H4a2 2 0 0 0-2 2v9a2 2 0 0 0 2 2h2l3 3z"}],
  ["path",{"d":"M6 8v1"}],
  ["path",{"d":"M10 8v1"}],
  ["path",{"d":"M14 8v1"}],
  ["path",{"d":"M18 8v1"}]
])

github-actions[bot] avatar May 03 '24 08:05 github-actions[bot]

What about arcifying the eathernet-port icon?

icons
Open lucide studio

jguddas avatar May 03 '24 08:05 jguddas

wired-connection feels an oddly specific name for an abstract symbol that to my best knowledge is not a standard representation of said concept, so maybe arrow-double(-headed)-horizontal-dashed or something similar would be better?

karsa-mistmere avatar May 03 '24 08:05 karsa-mistmere

@karsa-mistmere Kinda true. It's more common than you might think. image image

Wiki: https://en.wikipedia.org/wiki/Ethernet So not sure if we should choose a generic name since it is possibly recognized as a symbol for ethernet. But I get you, I still have some doubts about the name. 🤔

ericfennis avatar May 03 '24 09:05 ericfennis

@karsa-mistmere Kinda true. It's more common than you might think. image image

Wiki: https://en.wikipedia.org/wiki/Ethernet So not sure if we should choose a generic name since it is possibly recognized as a symbol for ethernet. But I get you, I still have some doubts about the name. 🤔

Still feel like it is describing the use case rather than what is actually depicting.

jguddas avatar May 03 '24 12:05 jguddas

@jguddas @karsa-mistmere I've renamed it to chevrons-left-right-ellipsis

ericfennis avatar Aug 02 '24 10:08 ericfennis