lucide icon indicating copy to clipboard operation
lucide copied to clipboard

fix(icons): redesigned `home` icon

Open jguddas opened this issue 9 months ago • 7 comments

What is the purpose of this pull request?

  • [x] Other: Icon update

Description

Redesigned home icon

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

jguddas avatar May 02 '24 17:05 jguddas

Added or changed icons

icons/house.svg
Preview cohesion icons/square-user-round.svg
icons/house.svg
icons/drama.svg
Preview stroke widths icons/house.svg
icons/house.svg
icons/house.svg
DPI Preview (24px) icons/house.svg
Icon X-rays icons/house.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const HouseIcon = createLucideIcon('House', [
  ["path",{"d":"M15 21v-8a1 1 0 0 0-1-1h-4a1 1 0 0 0-1 1v8"}],
  ["path",{"d":"M3 10a2 2 0 0 1 .709-1.528l7-5.999a2 2 0 0 1 2.582 0l7 5.999A2 2 0 0 1 21 10v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2z"}]
])

github-actions[bot] avatar May 02 '24 17:05 github-actions[bot]

What makes the curved door feel weird to you @karsa-mistmere? Looks pretty neat at 12x to me. Frame

jguddas avatar May 03 '24 07:05 jguddas

Also up for discussion: should we rename this to house?

karsa-mistmere avatar May 03 '24 07:05 karsa-mistmere

What makes the curved door feel weird to you @karsa-mistmere? Looks pretty neat at 12x to me. Frame

To me that looks awful, I very much prefer the right one:

image


Edit: I know now why exactly this is bugging me – adding rounding that's invisible at our default settings means that scaled/light icons are fundamentally different, I think this is definitely undesirable.

karsa-mistmere avatar May 03 '24 07:05 karsa-mistmere

Can we also take a look at #1841 before we merge this one.

Other related issues:

  • #2098
  • #1855

ericfennis avatar May 03 '24 10:05 ericfennis

Can we also take a look at #1841 before we merge this one.

Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates: image

None of them spark joy, but it should definitely not be the last one.

karsa-mistmere avatar May 03 '24 15:05 karsa-mistmere

Can we also take a look at #1841 before we merge this one. Other related issues:

@jguddas already designed this very cute icon at #2123 for the autarky use case

As for home-plus (or should it not be house-plus?), I think these are our best candidates: image

None of them spark joy, but it should definitely not be the last one.

The second one with the plus in the roof looks nice.

jguddas avatar May 03 '24 16:05 jguddas

@karsa-mistmere @jguddas I vote as well for the second one!

ericfennis avatar Jun 02 '24 08:06 ericfennis

Also up for discussion: should we rename this to house?

This still bugs me, I feel like house is what's depicted and home is a use case, so as per naming convention no. 4, this should be house, not home.

karsa-mistmere avatar Jun 02 '24 09:06 karsa-mistmere

Also up for discussion: should we rename this to house?

This still bugs me, I feel like house is what's depicted and home is a use case, so as per naming convention no. 4, this should be house, not home.

@ericfennis & @jguddas: still waiting for your two cents on this.


Here's the finalized house-plus/home-plus icon:

icons
Open lucide studio

karsa-mistmere avatar Jun 13 '24 08:06 karsa-mistmere

I vote for keeping it home.

jguddas avatar Jun 13 '24 08:06 jguddas

@karsa-mistmere is right here. If we want to be consistent with renaming, we should rename this to house.

ericfennis avatar Jun 14 '24 14:06 ericfennis