lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Potential compatibility with shadow DOM

Open unit-404 opened this issue 10 months ago • 2 comments

When using custom elements, needs to create icons again when inside of shadow DOM. Shadow DOM invisible from document selectors, so can't be replaced directly. There is no new any icon.

What is the purpose of this pull request?

  • [ ] New Icon
  • [ ] Bug fix
  • [x] New Feature
  • [ ] Documentation update
  • [x] Other:

Description

Adds rootElement field for createIcons (default, is document).

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

unit-404 avatar Apr 18 '24 07:04 unit-404

@unit-404 Cool idea! Did you already get it working?

Maybe we can also test this with libraries like Lit.

ericfennis avatar Apr 26 '24 15:04 ericfennis

About get working, I did it in separate code (re-wrap). I.e. re-created that function.

unit-404 avatar Apr 27 '24 01:04 unit-404

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 27 '24 02:05 github-actions[bot]