lucide icon indicating copy to clipboard operation
lucide copied to clipboard

feat(icons): add guillemets

Open gurtt opened this issue 10 months ago • 4 comments

What is the purpose of this pull request?

  • [x] New Icon
  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other:

Description

Adds guillemets icon.

Icon use case

This icon represents guillemets, which are used as quotation marks in many regions as well as other uses:

  • quotation mark in several regions
  • in UML to indicate a stereotype
  • in Microsoft Word as a mail merge field

Note that these are separate from chevrons and angle brackets, which have different uses and appearances. This icon more visually matches parentheses, brackets, and braces.

Alternative icon designs

Icon Design Checklist

Concept

  • [x] I have provided valid use cases for each icon.
  • [x] I have not added any a brand or logo icon.
  • [x] I have not used any hate symbols.
  • [x] I have not included any religious or political imagery.

Author, credits & license

  • [x] The icons are solely my own creation.
  • [ ] The icons were originally created in #<issueNumber> by @<githubUser>
  • [ ] I've based them on the following Lucide icons:
  • [ ] I've based them on the following design:

Naming

  • [x] I've read and followed the naming conventions
  • [x] I've named icons by what they are rather than their use case.
  • [x] I've provided meta JSON files in icons/[iconName].json.

Design

  • [x] I've read and followed the icon design guidelines
  • [x] I've made sure that the icons look sharp on low DPI displays.
  • [x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • [x] I've made sure that the icons are visually centered.
  • [x] I've correctly optimized all icons to three points of precision.

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

gurtt avatar Apr 04 '24 07:04 gurtt

Added or changed icons

icons/guillemets.svg
Preview cohesion icons/square-check.svg
icons/guillemets.svg
icons/pie-chart.svg
Preview stroke widths icons/guillemets.svg
icons/guillemets.svg
icons/guillemets.svg
DPI Preview (24px) icons/guillemets.svg
Icon X-rays icons/guillemets.svg

Icons as code

Only working for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const GuillemetsIcon = createLucideIcon('Guillemets', [
  ["path",{"d":"m10 3-2.895 8.684a1 1 0 0 0 0 .632L10 21"}],
  ["path",{"d":"m14 3 2.895 8.684c.068.205.068.427 0 .632L14 21"}],
  ["path",{"d":"m19 3 2.895 8.684c.068.205.068.427 0 .632L19 21"}],
  ["path",{"d":"m5 3-2.895 8.684a1 1 0 0 0 0 .632L5 21"}]
])

github-actions[bot] avatar Apr 04 '24 07:04 github-actions[bot]

Should the icon not match with chevrons-left-right and chevrons-left?

ericfennis avatar Apr 05 '24 13:04 ericfennis

Should the icon not match with chevrons-left-right and chevrons-left?

Yeah, true, these look much more like double angle brackets than guillemets.

karsa-mistmere avatar Apr 05 '24 13:04 karsa-mistmere

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 06 '24 02:05 github-actions[bot]