lucide icon indicating copy to clipboard operation
lucide copied to clipboard

feat(icons): adds `barrel` icon

Open karsa-mistmere opened this issue 11 months ago • 15 comments

What is the purpose of this pull request?

  • [x] New Icon

Description

Icon use case

  • to indicate drinks, especially alcoholic drinks usually aged in barrels (wine, beer, whiskey)
  • to symbolise breweries/distilleries in map apps

Icon Design Checklist

Concept

  • [x] I have provided valid use cases for each icon.
  • [x] I have not added any a brand or logo icon.
  • [x] I have not used any hate symbols.
  • [x] I have not included any religious or political imagery.

Author, credits & license

  • [x] The icons are solely my own creation.

Naming

  • [x] I've read and followed the naming conventions
  • [x] I've named icons by what they are rather than their use case.
  • [x] I've provided meta JSON files in icons/[iconName].json.

Design

  • [x] I've read and followed the icon design guidelines
  • [x] I've made sure that the icons look sharp on low DPI displays.
  • [x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • [x] I've made sure that the icons are visually centered.
  • [x] I've correctly optimized all icons to two points of precision.

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

karsa-mistmere avatar Mar 07 '24 22:03 karsa-mistmere

Added or changed icons

icons/barrel.svg
Preview cohesion icons/square-parking-off.svg
icons/barrel.svg
icons/send-horizontal.svg
Preview stroke widths icons/barrel.svg
icons/barrel.svg
icons/barrel.svg
DPI Preview (24px) icons/barrel.svg
Icon X-rays icons/barrel.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const BarrelIcon = createLucideIcon('Barrel', [
  ["path",{"d":"M16 20.5v-17"}],
  ["path",{"d":"M8 3.5v17"}],
  ["path",{"d":"M2 10a50.5 50.5 0 0 1 20 0"}],
  ["path",{"d":"M2 14a50.5 50.5 0 0 0 20 0"}],
  ["path",{"d":"M21.16 5.677A17 17 0 0 0 12 3a17 17 0 0 0-9.16 2.677A2 2 0 0 0 2 7.268v9.464a2 2 0 0 0 .84 1.591A17 17 0 0 0 12 21a17 17 0 0 0 9.16-2.677 2 2 0 0 0 .84-1.591V7.268a2 2 0 0 0-.84-1.591"}]
])

github-actions[bot] avatar Mar 07 '24 22:03 github-actions[bot]

Feels more like a skewed table than a barrel to me.

jguddas avatar Mar 08 '24 06:03 jguddas

I don't see the barrel as well. Maybe something based on the database icon?

ericfennis avatar Mar 08 '24 11:03 ericfennis

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one.

I've tried an isometric view but it's super icky: image

karsa-mistmere avatar Mar 08 '24 11:03 karsa-mistmere

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one.

I've tried an isometric view but it's super icky: image

The isometric one looks cute and barrely.

jguddas avatar Mar 08 '24 11:03 jguddas

I don't see the barrel as well. Maybe something based on the database icon?

It's a wine barrel, not an oil one. I've tried an isometric view but it's super icky: image

The isometric one looks cute and barrely.

It looks like a hand grenade.

karsa-mistmere avatar Mar 08 '24 11:03 karsa-mistmere

Maybe giving it a tap and some feet can help? image

Another icon: https://www.iconfinder.com/icons/5380899/barrel_drum_faucet_tap_water_icon

ericfennis avatar Apr 05 '24 08:04 ericfennis

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar May 09 '24 02:05 github-actions[bot]

@karsa-mistmere What about this design?

image

ericfennis avatar Jun 14 '24 10:06 ericfennis

@karsa-mistmere What about this design?

image

I explored something similar but it's just too dense this way.

karsa-mistmere avatar Jun 14 '24 10:06 karsa-mistmere

I think it is not that bad

ericfennis avatar Jun 14 '24 13:06 ericfennis

I think it is not that bad

Well, in practice the corners do not fulfil the 2px gap rule, I'm afraid. 😅

karsa-mistmere avatar Jun 14 '24 14:06 karsa-mistmere

Hmm true, this is also an option, but looks denser image

ericfennis avatar Jun 14 '24 14:06 ericfennis

Hmm true, this is also an option, but looks denser image

In this case, it's the central segments of each side that do not have sufficient gaps. :/

karsa-mistmere avatar Jun 14 '24 14:06 karsa-mistmere

Hmm true, this is also an option, but looks denser image

Still no joy to be sparked :/

jguddas avatar Jun 14 '24 14:06 jguddas

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 04 '24 02:08 github-actions[bot]