lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Published 20 hours ago • verified publisher icon lucide-icons

Show related PR(s) in Icon details

Open zaaakher opened this issue 1 year ago • 5 comments

Package

  • [ ] lucide
  • [ ] lucide-angular
  • [ ] lucide-flutter
  • [ ] lucide-preact
  • [ ] lucide-react
  • [ ] lucide-react-native
  • [ ] lucide-solid
  • [ ] lucide-svelte
  • [ ] lucide-vue
  • [ ] lucide-vue-next
  • [ ] Figma plugin
  • [ ] all JS packages
  • [X] site

Description

Just a small idea, if there's a button next to the contributors that links to the PR (or multiple PRs) related to that Icon so the we can go to the PR to see the discussion leading to the final decision

👇here's a quick mockup of how it would look like: image Notice the PR number next to the contributors

Use cases

I was going through some of the icons and I noticed that shield-off and shield-ban have very different contributors and I noticed an inconsistency with the degree of the diagonal line and I was wondering if there was a discussion regarding that decision so I had that idea of linking all PRs related to the icon so people can trace all discussions related to the icon to understand reasons behind certain design decisions.

Checklist

  • [X] I have searched the existing issues to make sure this bug has not already been reported.

zaaakher avatar Nov 17 '23 10:11 zaaakher

I just noticed I can click on the "last changed" part of the icon

image

which will take me to the release which can lead me to the related PR's and that way I can find the relevant discussion

Perhaps the "last changed" release tag could be added to the icon quick view in one of these areas 👇? image

zaaakher avatar Nov 17 '23 10:11 zaaakher

What about merging the two detail views into one by creating a scrollable bottom sheet like this? https://play.tailwindcss.com/tIdRAz5DcD

jguddas avatar Nov 17 '23 11:11 jguddas

@zaaakher Yeah good idea!

ericfennis avatar Nov 17 '23 12:11 ericfennis

What about merging the two detail views into one by creating a scrollable bottom sheet like this? https://play.tailwindcss.com/tIdRAz5DcD

Yes that would be great 👍 especially that the X button will close it and I can easily search for another icon

👇 currently in the full page detailed view there's no way to search for another icon, I have to click on the "icons" button in the nav bar to go back image

zaaakher avatar Nov 17 '23 13:11 zaaakher

Or there could be a search bar in the detailed page like this 👇 image

But that might be antithetical to the "related icons" concept

zaaakher avatar Nov 17 '23 13:11 zaaakher