lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Make site Lucide.dev into PWA

Open chessurisme opened this issue 1 year ago • 8 comments

Package

  • [ ] lucide
  • [ ] lucide-angular
  • [ ] lucide-flutter
  • [ ] lucide-preact
  • [ ] lucide-react
  • [ ] lucide-react-native
  • [ ] lucide-solid
  • [ ] lucide-svelte
  • [ ] lucide-vue
  • [ ] lucide-vue-next
  • [ ] Figma plugin
  • [ ] all JS packages
  • [X] site

Description

Please add Service Worker in the main site to make PWA for accessibility, and I suggest to make the searching icon function be offline. It is easy to access in mobile while working on workspace.

Use cases

I am searching icons back and then in the site, and it cost data and loading time. Especially when got refreshed. PWA handles this. Some of devs has low connection sometimes. Please add PWA and add offline capabilities for easy to use.

Checklist

  • [X] I have searched the existing issues to make sure this bug has not already been reported.

chessurisme avatar Nov 07 '23 10:11 chessurisme

This could be helpful https://github.com/vite-pwa/vitepress @ericfennis

zaaakher avatar Nov 07 '23 15:11 zaaakher

While the site is not a PWA, searching for icons is already done offline, so it shouldn't cost you any extra data whatsoever to do so once the icons page has loaded, I've tested this by going offline, the search functionality remains intact.

Can you please explain why you think this might not be the case?

karsa-mistmere avatar Nov 07 '23 15:11 karsa-mistmere

We do have an issue with the current cache configuration, we are aware and are planning to fix it.

I'm not opposed, to vite-pwa, but also can't say that it has ever been worth it for me to spend time implementing it.

jguddas avatar Nov 07 '23 19:11 jguddas

While the site is not a PWA, searching for icons is already done offline, so it shouldn't cost you any extra data whatsoever to do so once the icons page has loaded, I've tested this by going offline, the search functionality remains intact.

Can you please explain why you think this might not be the case?

Making the site PWA offer many benefits that can significantly improve the user experience, including faster load times, reduced data usage (as I mentioned earlier), and cross-platform compatibility (I am using my Windows and Android always when visiting the site.)

By caching assets and content, PWAs provide quicker loading speeds during subsequent visits. I always visit the site now and then, and it load slower sometimes on my Windows due to low of connection. We are saving data here because it cost so much.

That is why implementing a PWA in Lucide.dev can be a very good option, it optimize performance, minimize data costs, and expand accessibility across devices—all of which contribute to an enhanced user experience. 😁

chessurisme avatar Nov 08 '23 00:11 chessurisme

This doesn't really answer my question though. You'd stated that

searching icons [...] in the site cost[s] data and loading time

I've found no indication of such data cost, do you have any experience that says otherwise and if so where should I be looking?

karsa-mistmere avatar Nov 09 '23 15:11 karsa-mistmere

My apologies about my previous comment, I don't have problems when site is loaded. Also you are correct it works offline when searching icons. The only thing I want is whenever I visit the site again, I'd like it to work offline (as what PWA does). Just because it costs data and loading time when I visit again on the next few hours or next day. I do close my browser when my tasks ends, so maybe implementing offline capabilities may help. So when opening the site without connection loads directly in ease. Also whenever the user connected to the internet, it only download the assets added, depends on the tweaks of devs.

P.S. I am deeply sorry about what I said earlier. 😔

chessurisme avatar Nov 10 '23 01:11 chessurisme

It's ok, I was just concerned you were experiencing some bug that I couldn't reproduce and just wanted some additional context.

As @jguddas said,

We do have an issue with the current cache configuration, we are aware and are planning to fix it.

This should resolve most performance issues.

We'll definitely also look into the possibility of PWA but I can't make any promises. :)

karsa-mistmere avatar Nov 10 '23 05:11 karsa-mistmere

Thank you for your sincere consideration. I highly appreciate that! ❤️ Also, check for Workbox when doing service worker it helps! 😁

chessurisme avatar Nov 10 '23 12:11 chessurisme