lucide icon indicating copy to clipboard operation
lucide copied to clipboard

add trending-flat icon

Open jonas-hoebenreich opened this issue 1 year ago • 7 comments

What is the purpose of this pull request?

  • [x] New Icon
  • [ ] Bug fix
  • [ ] New Feature
  • [ ] Documentation update
  • [ ] Other:

Description

The 'trending-flat' icon depicts a wavy line, symbolizing a neutral or stable trend with minor fluctuations, ideal for representing periods of minimal change in financial or market data. image

Icon use case

The icon can be used in financial reports and dashboards to represent periods of stability or minimal changes in stock prices, economic indicators, or market trends. It can also be utilized in data visualization to indicate a neutral or flat trend in graphs and charts.

Alternative icon designs

image

Icon Design Checklist

Concept

  • [x] I have provided valid use cases for the icon.
  • [x] I have not added any brand or logo icon.
  • [x] I have not used any hate symbols.
  • [x] I have not included any religious or political imagery.

Author, credits & license

  • [ ] The icon is solely my own creation.
  • [ ] The icon was originally created in #<issueNumber> by @<githubUser>
  • [x] I've based it on the following Lucide icons: move-right
  • [ ] I've based it on the following design:

Naming

  • [x] I've read and followed the naming conventions
  • [x] I've named the icon by what it is rather than its use case.
  • [x] I've provided meta JSON files in icons/[iconName].json.

Design

  • [x] I've read and followed the icon design guidelines
  • [x] I've made sure that the icon looks sharp on low DPI displays.
  • [x] I've made sure that the icon looks consistent with the icon set in size, optical volume, and density.
  • [x] I've made sure that the icon is visually centered.
  • [x] I've correctly optimized the icon to two points of precision.

Before Submitting

  • [x] I've read the Contribution Guidelines.
  • [x] I've checked if there was an existing PR that solves the same issue.

jonas-hoebenreich avatar Nov 05 '23 17:11 jonas-hoebenreich

Added or changed icons

icons/trending-flat.svg
Preview cohesion icons/plus-square.svg
icons/trending-flat.svg
icons/user-cog.svg
Preview stroke widths icons/trending-flat.svg
icons/trending-flat.svg
icons/trending-flat.svg
DPI Preview (24px) icons/trending-flat.svg
Icon X-rays icons/trending-flat.svg

github-actions[bot] avatar Nov 05 '23 17:11 github-actions[bot]

I was just about to suggest using move-right for this use case, which actually has trend flat as a tag, but surely you must be aware of this, @jonas-hoebenreich, since move-right was also submitted by you. 😄

Still, I do personally think, move-right fits better with trending-up and trending-down than a wavy line would: image

karsa-mistmere avatar Nov 13 '23 09:11 karsa-mistmere

Good point @karsa-mistmere ! @jonas-hoebenreich Can move-right fit this usecase or can you explain why not?

ericfennis avatar Dec 01 '23 13:12 ericfennis

Well, a wavy arrow can be used to symbolize that something does not run in a straight line. However, if you only have straight arrows, this aspect is eliminated.

jonas-hoebenreich avatar Dec 03 '23 18:12 jonas-hoebenreich

@jonas-hoebenreich Good point. I'm fine with adding this kind of icon. But I understand @karsa-mistmere doubts about the design. It's not matching the other trending icons very well. Maybe we can try to make some alternatives?

ericfennis avatar Dec 13 '23 19:12 ericfennis

How about a more rectangular approach to better match the style of current trending icons?

image

In either case, should we add this icon, I think it should be named arrow-right-wavy or something similar in line with our icon naming guidelines.

karsa-mistmere avatar Jan 09 '24 20:01 karsa-mistmere

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 23 '24 01:02 github-actions[bot]