lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Sort out `loader`/cursor icons

Open danielbayley opened this issue 1 year ago • 9 comments

danielbayley avatar Jun 03 '23 10:06 danielbayley

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jun 03 '23 10:06 vercel[bot]

Added or changed icons

icons/loader-pinwheel.svgicons/mouse-pointer-ban.svgicons/loader.svg

Preview cohesion icons/message-square.svgicons/square-user.svgicons/square-arrow-right.svg
icons/loader-pinwheel.svgicons/mouse-pointer-ban.svgicons/loader.svg
icons/message-square-share.svgicons/filter.svgicons/whole-word.svg
Preview stroke widths icons/loader-pinwheel.svgicons/mouse-pointer-ban.svgicons/loader.svg
icons/loader-pinwheel.svgicons/mouse-pointer-ban.svgicons/loader.svg
icons/loader-pinwheel.svgicons/mouse-pointer-ban.svgicons/loader.svg
DPI Preview (24px) icons/loader-pinwheel.svg icons/mouse-pointer-ban.svg icons/loader.svg
Icon X-rays icons/loader-pinwheel.svg icons/mouse-pointer-ban.svg icons/loader.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const LoaderPinwheelIcon = createLucideIcon('LoaderPinwheel', [
  ["path",{"d":"M2 12c0-2.8 2.2-5 5-5s5 2.2 5 5 2.2 5 5 5 5-2.2 5-5"}],
  ["path",{"d":"M7 20.7a1 1 0 1 1 5-8.7 1 1 0 1 0 5-8.6"}],
  ["path",{"d":"M7 3.3a1 1 0 1 1 5 8.6 1 1 0 1 0 5 8.6"}],
  ["circle",{"cx":"12","cy":"12","r":"10"}]
])

const MousePointerBanIcon = createLucideIcon('MousePointerBan', [
  ["path",{"d":"m2 2 4 11 2-5 5-2Z"}],
  ["circle",{"cx":"16","cy":"16","r":"6"}],
  ["path",{"d":"m11.8 11.8 8.4 8.4"}]
])

const LoaderIcon = createLucideIcon('Loader', [
  ["path",{"d":"M12 2v4"}],
  ["path",{"d":"m16.2 7.8 2.9-2.9"}],
  ["path",{"d":"M18 12h4"}],
  ["path",{"d":"m16.2 16.2 2.9 2.9"}],
  ["path",{"d":"M12 18v4"}],
  ["path",{"d":"m4.9 19.1 2.9-2.9"}],
  ["path",{"d":"M2 12h4"}],
  ["path",{"d":"m4.9 4.9 2.9 2.9"}]
])

github-actions[bot] avatar Jun 03 '23 10:06 github-actions[bot]

Not a fan of adding all kinds of states of the loader, we might as well add different rotations of the circle loader, but there are much better ways of animating than changing icons.

karsa-mistmere avatar Jun 03 '23 12:06 karsa-mistmere

Not a fan of adding all kinds of states of the loader, we might as well add different rotations of the circle loader, but there are much better ways of animating than changing icons.

@karsa-mistmere reverted…

danielbayley avatar Jun 03 '23 13:06 danielbayley

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lucide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2023 9:26pm

vercel[bot] avatar Jun 06 '23 01:06 vercel[bot]

I'm not a big fan of loader-circle-big.

loader-pinwheel could maybe be circle-pinwheel instead? 🤔

mouse-pointer-ban is super useful though!

karsa-mistmere avatar Jul 17 '23 12:07 karsa-mistmere

loader-pinwheel could maybe be circle-pinwheel instead? 🤔

@karsa-mistmere Shouldn’t loader-* icons be grouped by prefix, like others? Or maybe cursor-pinwheel? If not, maybe even spinning-pinwheel? See: https://en.wikipedia.org/wiki/Spinning_pinwheel. cc: @jguddas @ericfennis

danielbayley avatar Jul 17 '23 20:07 danielbayley

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Aug 27 '23 01:08 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 08 '24 01:02 github-actions[bot]

  • circle-big: weird name but okay with me.
  • pinwheel: needs some path optimization

jguddas avatar Apr 19 '24 13:04 jguddas