lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Add `id-card`

Open jguddas opened this issue 1 year ago • 16 comments

Resolves #953

jguddas avatar May 19 '23 16:05 jguddas

@jguddas is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 19 '23 16:05 vercel[bot]

Added or changed icons

icons/id-card.svg
Preview cohesion icons/square-check.svg
icons/id-card.svg
icons/subscript.svg
Preview stroke widths icons/id-card.svg
icons/id-card.svg
icons/id-card.svg
DPI Preview (24px) icons/id-card.svg
Icon X-rays icons/id-card.svg
Icons as code

Works for: lucide-react, lucide-react-native, lucide-preact, lucide-vue-next

const IdCardIcon = createLucideIcon('IdCard', [
  ["path",{"d":"M16 10h2"}],
  ["path",{"d":"M16 14h2"}],
  ["path",{"d":"M6.17 15a3 3 0 0 1 5.66 0"}],
  ["circle",{"cx":"9","cy":"11","r":"2"}],
  ["rect",{"x":"2","y":"5","width":"20","height":"14","rx":"2"}]
])

github-actions[bot] avatar May 19 '23 16:05 github-actions[bot]

Maybe let's call this id-badge instead, although I'm not quite happy about the user shape still.

karsa-mistmere avatar May 22 '23 19:05 karsa-mistmere

@karsa-mistmere I get you, but at the same time I'm not sure if we will come up with an alternative. But if you want to make more iterations on this, it's better if we close this one and continue in #953.

ericfennis avatar May 31 '23 17:05 ericfennis

I still definitely want to make this work within the bounds of credit card, to be consistent: image image

I feel like taking into consideration discussions in #609, these should be able to work.

karsa-mistmere avatar Jun 01 '23 08:06 karsa-mistmere

@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?

ericfennis avatar Jul 30 '23 19:07 ericfennis

@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?

Sure: id-card

karsa-mistmere avatar Jul 31 '23 06:07 karsa-mistmere

LGTM @karsa-mistmere Go with that one?

ericfennis avatar Aug 28 '23 17:08 ericfennis

Now we have a 1px gap violation between the head and the body.

jguddas avatar Oct 06 '23 06:10 jguddas

Now we have a 1px gap violation between the head and the body.

Yes, but see https://github.com/lucide-icons/lucide/issues/609#issuecomment-1203678217

karsa-mistmere avatar Oct 06 '23 07:10 karsa-mistmere

Now we have a 1px gap violation between the head and the body.

Yes, but see #609 (comment)

The violation is not really worth it, the whole icon hasn't been that hugely requested, and I'm fine with just closing this PR as well.

jguddas avatar Oct 06 '23 09:10 jguddas

I think we could make an exception for this one to accept this small violation. Let's find a balance between making it recognizable, and consistent and between our guidelines. But with some, we could make exceptions. This icon has a valid usecase and is valuable in modern applications. It would be a shame if we couldn't do this because of a small violation.

I'm curious what you think of this.

ericfennis avatar Oct 06 '23 09:10 ericfennis

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jan 15 '24 02:01 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 19 '24 01:02 github-actions[bot]

New idea: icon - 2024-03-28T222422 505

icons
Open lucide studio

jguddas avatar Mar 28 '24 21:03 jguddas

New idea: icon - 2024-03-28T222422 505

iconsOpen lucide studio

Pretty neat idea, I love it! Maybe it should be left to right though, I think that's a much more common layout.

karsa-mistmere avatar Mar 28 '24 22:03 karsa-mistmere

Hmm, still not convinced with the design, to me looks a bit weird that the user icon is out of the boundaries of the card.. 🤔

Yeah, I kinda agree. How about this one? It's maybe a bit dense, but not that bad, I guess, we definitely have worse icons by density.

image

icons
Open lucide studio

karsa-mistmere avatar Jul 16 '24 08:07 karsa-mistmere

Alternatively:

image

icons
Open lucide studio

karsa-mistmere avatar Jul 16 '24 08:07 karsa-mistmere

@karsa-mistmere The one you first posted seems to fit fine. On 100% scale it looks like a perfect id-card to me.

ericfennis avatar Jul 16 '24 12:07 ericfennis

Alternatively:

image

iconsOpen lucide studio

I like this one, the first one not so much, the body has a bit of a weird gap on the lower left tho.

image

jguddas avatar Jul 16 '24 12:07 jguddas

Like Eric, I prefer the first one:

image

iconsOpen lucide studio

karsa-mistmere avatar Jul 20 '24 17:07 karsa-mistmere

Like Eric, I prefer the first one:

image iconsOpen lucide studio

Feels to dense for me.

jguddas avatar Jul 20 '24 17:07 jguddas

Like Eric, I prefer the first one:

image iconsOpen lucide studio

Feels to dense for me.

A bit too dense for my liking as well, but I think it's still better than any alternatives so far and it's not extremely dense by any means.

karsa-mistmere avatar Jul 20 '24 17:07 karsa-mistmere

Hello there!

Is there any chance to merge this ? I would definitely fine with the latest version :)

gyurielf avatar Jul 31 '24 11:07 gyurielf