lucide
lucide copied to clipboard
Add `id-card`
Resolves #953
@jguddas is attempting to deploy a commit to the Lucide Team on Vercel.
A member of the Team first needs to authorize it.
Added or changed icons
Preview cohesion
Preview stroke widths
DPI Preview (24px)
Icon X-rays
Icons as code
Works for: lucide-react
, lucide-react-native
, lucide-preact
, lucide-vue-next
const IdCardIcon = createLucideIcon('IdCard', [
["path",{"d":"M16 10h2"}],
["path",{"d":"M16 14h2"}],
["path",{"d":"M6.17 15a3 3 0 0 1 5.66 0"}],
["circle",{"cx":"9","cy":"11","r":"2"}],
["rect",{"x":"2","y":"5","width":"20","height":"14","rx":"2"}]
])
Maybe let's call this id-badge
instead, although I'm not quite happy about the user shape still.
@karsa-mistmere I get you, but at the same time I'm not sure if we will come up with an alternative. But if you want to make more iterations on this, it's better if we close this one and continue in #953.
I still definitely want to make this work within the bounds of credit card, to be consistent:
I feel like taking into consideration discussions in #609, these should be able to work.
@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?
@karsa-mistmere Yeah good point. I like the second one, can we increase the length of the text lines a bit?
Sure:
LGTM @karsa-mistmere Go with that one?
Now we have a 1px gap violation between the head and the body.
Now we have a 1px gap violation between the head and the body.
Yes, but see https://github.com/lucide-icons/lucide/issues/609#issuecomment-1203678217
Now we have a 1px gap violation between the head and the body.
Yes, but see #609 (comment)
The violation is not really worth it, the whole icon hasn't been that hugely requested, and I'm fine with just closing this PR as well.
I think we could make an exception for this one to accept this small violation. Let's find a balance between making it recognizable, and consistent and between our guidelines. But with some, we could make exceptions. This icon has a valid usecase and is valuable in modern applications. It would be a shame if we couldn't do this because of a small violation.
I'm curious what you think of this.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.
New idea:
Pretty neat idea, I love it! Maybe it should be left to right though, I think that's a much more common layout.
Hmm, still not convinced with the design, to me looks a bit weird that the user icon is out of the boundaries of the card.. 🤔
Yeah, I kinda agree. How about this one? It's maybe a bit dense, but not that bad, I guess, we definitely have worse icons by density.
@karsa-mistmere The one you first posted seems to fit fine. On 100% scale it looks like a perfect id-card to me.
Alternatively:
I like this one, the first one not so much, the body has a bit of a weird gap on the lower left tho.
Like Eric, I prefer the first one:
Feels to dense for me.
A bit too dense for my liking as well, but I think it's still better than any alternatives so far and it's not extremely dense by any means.
Hello there!
Is there any chance to merge this ? I would definitely fine with the latest version :)