lucide icon indicating copy to clipboard operation
lucide copied to clipboard

Add/refine `play`/etc… icons

Open danielbayley opened this issue 1 year ago • 22 comments

danielbayley avatar Apr 11 '23 13:04 danielbayley

Yeah, I'm afraid this just won't do the job. 😐

I do realize that stop is missing from our playback icons (in fact, I have a bunch of playback icon drafts because of this), but - and this is a big but - I'm afraid square is not a good fit at all, since it has a completely different style and size than our other playback icons. image

I can see two possible options:

  1. we can add a dedicated stop icon that matches our playback icons:

image

  1. we can update our current playback icons to match the style of square, with the latter standing in as stop:

image

@ericfennis, what do you think?

karsa-mistmere avatar Apr 11 '23 14:04 karsa-mistmere

I keep opening new cans of worms 😅

FWIW, I think option 1.

danielbayley avatar Apr 11 '23 14:04 danielbayley

I keep opening new cans of worms 😅

Yeah, haha, I've already found this can of worms, and was like

Oh. Noooope, I'll deal with this later, thank you very much indeed *glues-back-lid-of-can*

karsa-mistmere avatar Apr 11 '23 14:04 karsa-mistmere

Added or changed icons

icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg

Preview cohesion icons/chevron-up-square.svgicons/square-user-round.svgicons/message-square-heart.svgicons/play-square.svgicons/square.svgicons/function-square.svgicons/gantt-chart-square.svgicons/terminal-square.svgicons/power-square.svg
icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg
icons/book.svgicons/chevron-up-square.svgicons/badge-check.svgicons/corner-right-down.svgicons/usb.svgicons/user-minus.svgicons/panel-right.svgicons/pen-line.svgicons/image-plus.svg
Preview stroke widths icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg
icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg
icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg
DPI Preview (24px) icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg
Icon X-rays icons/play-all.svgicons/fast-forward.svgicons/pause.svgicons/play.svgicons/rewind.svgicons/skip-back.svgicons/skip-forward.svgicons/step-back.svgicons/step-forward.svg

github-actions[bot] avatar Apr 12 '23 16:04 github-actions[bot]

@danielbayley @karsa-mistmere hmm interesting discussion. I think we should get some more opinions on this one. Version 2 from Karsa looks a bit more Lucide-like to me. But maybe from a functionality perspective not always the best choice.

ericfennis avatar Apr 16 '23 16:04 ericfennis

What about the middle ground, say if we round the corners by 1px instead of 2…?

danielbayley avatar Apr 16 '23 16:04 danielbayley

So that's possibly option no. 3.

  1. Using square as is, but other playback icons now having 1px rounded corners: image

karsa-mistmere avatar Apr 16 '23 17:04 karsa-mistmere

So that's possibly option no. 3.

  1. Using square as is, but other playback icons now having 1px rounded corners: image

Yeah I think this is the way to go…

danielbayley avatar Apr 19 '23 16:04 danielbayley

  1. Using square as is, but other playback icons now having 1px rounded corners:

@karsa-mistmere @ericfennis Just pushed this approach…

danielbayley avatar Apr 20 '23 11:04 danielbayley

I think this is good to go, @karsa-mistmere what do you think?

ericfennis avatar May 02 '23 18:05 ericfennis

I like them 👍

jguddas avatar May 02 '23 19:05 jguddas

I think this is good to go, @karsa-mistmere what do you think?

Hmm... To be frank, I'm not entirely happy about some of these changes consistency wise, I'll make a side by side comparison as soon as I can get to it.

karsa-mistmere avatar May 02 '23 21:05 karsa-mistmere

OK, so here goes.

This is our current set: image

Overall pretty consistent, but:

  • Square sticks out like a sore thumb
  • Skip and steps have inconsistent line heights
  • The play shape itself is not very consistent

This is the current PR state: image

It's more Lucide-ish, but:

  • Pause and stop are significantly larger than the others (pause was increased in size to match square standing in for stop, but the others were not)
  • Skip and steps still have inconsistent line heights
  • The play shape itself is not very consistent

Possible alternatives:

A) Keeping a consistent arrow shape, but this leads to pretty inconsistent sizes and heights:

image


B) Keeping a (reasonably) consistent size and height while matching square, but this leads to disproportionate arrow shapes (especially in case of ff and rw):

image


C) Adding an extra stop icon that allows for better consistency in shape and size within the group, but this makes the group less consistent in size with the rest of the icons in the library:

image

karsa-mistmere avatar May 03 '23 07:05 karsa-mistmere

@karsa-mistmere Thanks for this sum-up. This is very useful. For me, I need some time to decide what the best is.

I'm curious about what others think!

ericfennis avatar May 03 '23 15:05 ericfennis

@karsa-mistmere Thanks for this sum-up. This is very useful. For me, I need some time to decide what the best is.

I'm curious about what others think!

Yeah, I'm afraid there is no obvious "best" solution here, all of them come with compromises. 😅

karsa-mistmere avatar May 03 '23 15:05 karsa-mistmere

all of them come with compromises. 😅

So often the case… 🙈

I'm curious about what others think!

I’m leaning toward option C, but could live with B…

danielbayley avatar May 03 '23 18:05 danielbayley

Ok after looking a second time, option C looks the best to me. Wat are the comprises and inconsistencies beside the stop button?

ericfennis avatar May 05 '23 06:05 ericfennis

this makes the group less consistent in size with the rest of the icons in the library

That sounds not so good.

jguddas avatar May 05 '23 13:05 jguddas

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 15 '23 17:05 vercel[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 15 '23 02:06 github-actions[bot]

That sounds not so good.

Always tradeoffs 😞

@jguddas Which option do you vote?

danielbayley avatar Jun 19 '23 13:06 danielbayley

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Feb 20 '24 01:02 github-actions[bot]