lucide
lucide copied to clipboard
Add/refine `play`/etc… icons
Yeah, I'm afraid this just won't do the job. 😐
I do realize that stop
is missing from our playback icons (in fact, I have a bunch of playback icon drafts because of this), but - and this is a big but - I'm afraid square
is not a good fit at all, since it has a completely different style and size than our other playback icons.
I can see two possible options:
- we can add a dedicated
stop
icon that matches our playback icons:
- we can update our current playback icons to match the style of
square
, with the latter standing in asstop
:
@ericfennis, what do you think?
I keep opening new cans of worms 😅
FWIW, I think option 1.
I keep opening new cans of worms 😅
Yeah, haha, I've already found this can of worms, and was like
Oh. Noooope, I'll deal with this later, thank you very much indeed *glues-back-lid-of-can*
Added or changed icons
Preview cohesion
Preview stroke widths
DPI Preview (24px)
Icon X-rays
@danielbayley @karsa-mistmere hmm interesting discussion. I think we should get some more opinions on this one. Version 2 from Karsa looks a bit more Lucide-like to me. But maybe from a functionality perspective not always the best choice.
What about the middle ground, say if we round the corners by 1px instead of 2…?
So that's possibly option no. 3.
- Using
square
as is, but other playback icons now having 1px rounded corners:
So that's possibly option no. 3.
- Using
square
as is, but other playback icons now having 1px rounded corners:![]()
Yeah I think this is the way to go…
- Using
square
as is, but other playback icons now having 1px rounded corners:
@karsa-mistmere @ericfennis Just push
ed this approach…
I think this is good to go, @karsa-mistmere what do you think?
I like them 👍
I think this is good to go, @karsa-mistmere what do you think?
Hmm... To be frank, I'm not entirely happy about some of these changes consistency wise, I'll make a side by side comparison as soon as I can get to it.
OK, so here goes.
This is our current set:
Overall pretty consistent, but:
- Square sticks out like a sore thumb
- Skip and steps have inconsistent line heights
- The play shape itself is not very consistent
This is the current PR state:
It's more Lucide-ish, but:
- Pause and stop are significantly larger than the others
(
pause
was increased in size to matchsquare
standing in forstop
, but the others were not) - Skip and steps still have inconsistent line heights
- The play shape itself is not very consistent
Possible alternatives:
A) Keeping a consistent arrow shape, but this leads to pretty inconsistent sizes and heights:
B) Keeping a (reasonably) consistent size and height while matching square
, but this leads to disproportionate arrow shapes (especially in case of ff and rw):
C) Adding an extra stop
icon that allows for better consistency in shape and size within the group, but this makes the group less consistent in size with the rest of the icons in the library:
@karsa-mistmere Thanks for this sum-up. This is very useful. For me, I need some time to decide what the best is.
I'm curious about what others think!
@karsa-mistmere Thanks for this sum-up. This is very useful. For me, I need some time to decide what the best is.
I'm curious about what others think!
Yeah, I'm afraid there is no obvious "best" solution here, all of them come with compromises. 😅
all of them come with compromises. 😅
So often the case… 🙈
I'm curious about what others think!
I’m leaning toward option C, but could live with B…
Ok after looking a second time, option C looks the best to me. Wat are the comprises and inconsistencies beside the stop button?
this makes the group less consistent in size with the rest of the icons in the library
That sounds not so good.
@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.
A member of the Team first needs to authorize it.
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.
That sounds not so good.
Always tradeoffs 😞
@jguddas Which option do you vote?
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.