Lucee icon indicating copy to clipboard operation
Lucee copied to clipboard

LDEV-3652 SerializeJSON ignores remotingFetch and SerializeJSON does not call custom getter function for component properties

Open mpark4656 opened this issue 3 years ago • 2 comments

SerializeJSON function should not ignore remoting fetch. SerializeJSON function should invoke the getter function of a component's property if one is defined for that property.

https://luceeserver.atlassian.net/browse/LDEV-3652

mpark4656 avatar Sep 21 '22 23:09 mpark4656

Application.cfc must have this.triggerDataMember set to true for the SerializeJSON function to access the getter functions. If triggerDataMember is not true, then SerializeJSON will work the way it did before this change.

mpark4656 avatar Sep 22 '22 01:09 mpark4656

@mpark4656 i raised a question about the wholesale changing of the true to false in the call to JSONConverter?

the test case is a good start, but we need tests to cover all the different behaviours, not just this specific use case

zspitzer avatar Sep 22 '22 10:09 zspitzer

@mpark4656 @zspitzer where are we on this PR, @zspitzer can we merge it in your opinion?

michaeloffner avatar Feb 12 '24 19:02 michaeloffner

@michaeloffner looks good to me, @mpark4656 has done great job with the test coverage

zspitzer avatar Feb 14 '24 03:02 zspitzer

i had to manually adapt this change, because merging this to 6.1 was nearly impossible, to much changed https://github.com/lucee/Lucee/commit/ad99628b5a2a528742f4b55c28a49d2f4771a68c

michaeloffner avatar Feb 19 '24 18:02 michaeloffner