Lucee
Lucee copied to clipboard
Catch named params left in QoQ SQL
This fixes the case where named params are used in a QoQ but no params are provided to the query.
https://luceeserver.atlassian.net/browse/LDEV-4044
@zspitzer @micstriit
[javac] /home/runner/work/Lucee/Lucee/core/src/main/java/lucee/runtime/sql/SelectParser.java:29: error: cannot find symbol
[javac] import lucee.runtime.exp.IllegalQoQException;
[javac] ^
[javac] symbol: class IllegalQoQException
[javac] location: package lucee.runtime.exp
[javac] /home/runner/work/Lucee/Lucee/core/src/main/java/lucee/runtime/sql/SelectParser.java:46: error: cannot find symbol
[javac] import lucee.runtime.exp.IllegalQoQException;
[javac] ^
[javac] symbol: class IllegalQoQException
[javac] location: package lucee.runtime.exp
[javac] Note: Processing Log4j annotations
[javac] Note: No elements to process
Weird, I'll check. This code is totally compiling and passing the tests here.
@zspitzer Oh, I know the issue. That class is in the other pull because this pull depends on the new functionality I added in the first pull. You'll need to merge that pull first.
@zspitzer When I did the work for this pull, I was working on the branch from the previous pull. I only pulled those changes over to this branch at the end when I committed them. That also means now that I think about it that after we merge the other pull, this one still won't pass until I rebase it to include those commits in this branch. I was just trying to keep the pulls organized, but wasn't thinking about it affecting the builds running in isolation. It seems every time I do QoQ tickets, they all overlap!
@zspitzer Ok, now that the other pull is merged, I tried rebasing this branch to include those commits. Hopefully I did the rebase right, and the tests will pass now!
Sigh, there's some random tests failing that have nothing to do with this ticket. I'm not sure if the rebase did what it was supposed to-- I hate Git sometimes, lol. @zspitzer I don't seem to have permissions, but can you re-run the failed build please. If it's still getting unrelated errors, I'll try re-creating the branch again.
re-trying this pull here: https://github.com/lucee/Lucee/pull/1816