Luc Berger

Results 228 comments of Luc Berger

@ndellingwood do you want to try a rebase and retest, I don't see why this should fail.

@e10harvey for some reason despite PR #1562 the build is not using openblas 0.3.20 as seen in Jenkins output and reproducer instruction. This CI is currently failing for that reason.

Note that I tested with the new openblas and the tests are passing with it, it's just not picked up by the script.

@tcclevenger can you apply clang-format to these file? You need to use the version from clang-8.0 for that. If you cannot let me know and I'll do it for you.

@mhoemmen I think that @nuraiman wants to call the communication avoiding GMRES using the xml interface. Is that already possible?

@mhoemmen fair comment, to be honest this has been there for a long time, I am suspecting that guards should have been implemented to switch between the two definitions. I...

@mhoemmen actually it is fine and somewhat necessary to have both definitions. The first one just defines a short hand type: `node_type` and the second one creates an alias: "Node...

Yeah, I'm not sure what it's state is to be honest... I would actually lean toward closing it and reworking the issue if this is still something we need.

@GrahamBenHarper Trilinos will start requiring c++17 very soon so it better means it supports it too: https://en.cppreference.com/w/cpp/language/attributes