remarks icon indicating copy to clipboard operation
remarks copied to clipboard

Change default page offset to 1

Open opal06 opened this issue 1 year ago • 2 comments

I think that while 0 seems the logical default offset from a programmer's perspective, 1 would actually be a better default as it would fit the average document pagination better. I can make a pull request, but as it's not a big change I wanted to bring it up here first.

Thanks for all the great work, sorry to bother you again!

opal06 avatar Mar 08 '23 11:03 opal06

You're right. It pains me a bit to change a flag's default value (due to backwards compatibility) but having it as 1 is just better long term.

Happy to merge your PR.

Thanks!

lucasrla avatar Mar 08 '23 14:03 lucasrla

@lucasrla I see the argument for backwards compatibility, but if someone really depends on the offset being 0, they should still be able to get that behaviour by setting the flag to 0 on program execution, right?

opal06 avatar Mar 11 '23 10:03 opal06