remarks icon indicating copy to clipboard operation
remarks copied to clipboard

Upgrade to rM v2.11

Open folofjc opened this issue 3 years ago • 4 comments

In my previous issue #37, I noted that the rM software will "snap" to text, and therefore make a new type of highlight. At the time, rM made each line a new highlight rectangle. Therefore, when I fixed this in PR #38, I assumed that there was one rectangle per highlight.

In rM v2.11, this is no longer true. You can highlight multiple lines or even a whole paragraph. Therefore there are multiple rectangles per highlight. Therefore I need to fix this. I will branch off my previous pull request.

folofjc avatar Dec 19 '21 14:12 folofjc

This should still be fixed in PR #38

folofjc avatar Dec 19 '21 16:12 folofjc

Version 2.11 also introduced green and pink colors for the highlighter, and blue and red colors for the pen tools. Could remarks also handle these? Currently the highlighter colors are all showing up as yellow, and the blue and red pen colors are throwing a KeyError.

allispaul avatar Dec 23 '21 12:12 allispaul

Ah, good point. I hadn't tested that. I might be able to try to fix that in my PR. RIght now the colors are indeed hard coded for the highlighter.

folofjc avatar Dec 23 '21 13:12 folofjc

Hi, I added support for highlighter colours in #44. I did not test the new pen colours yet but support should be trivial to implement.

haaase avatar Jun 05 '22 11:06 haaase

Hey @folofjc, could you share an example (it could a be zip file with a .metadata + .pdf + .rm + .highlights/*.json) that displays this behavior of "multiple rectangles per highlight"?

It'd be great to see this in practice.

Thanks in advance!

lucasrla avatar Oct 22 '22 01:10 lucasrla

Hey @lucasrla sorry, I am out of town. I was going to do this when I get back. But I guess you already figured it out? All you have to do is highlight a whole paragraph by swiping downward along the left edge of a paragraph.

folofjc avatar Oct 23 '22 19:10 folofjc

Yes, nevermind the example of overlapping highlights. I was able to reproduce it myself. Thanks!

lucasrla avatar Oct 23 '22 19:10 lucasrla