remarks icon indicating copy to clipboard operation
remarks copied to clipboard

Published 20 hours ago • verified publisher icon lucasrla

Fixing for the new highlights in rM v2.8 and 2.11. Refs #37 #39 #46 #47

Open folofjc opened this issue 2 years ago • 2 comments

My attempt to fix #37. I wrote a lot of comments so that you could see what I was doing. Feel free to re-factor, etc.

I tested it locally and it works great! I tested with the "old" annotations from pens as well as highlighter that did not get "modified". (i.e. I highlighted in the margins, etc, where there was no text).

folofjc avatar Sep 10 '21 12:09 folofjc

I just pushed again to my master with the fixes for #39. I think you can still use the same PR, right?

folofjc avatar Dec 19 '21 16:12 folofjc

Added support for #46 and #47

folofjc avatar Aug 05 '22 10:08 folofjc

@folofjc, thank you so much for taking the time to submit all these improvements. I'll resolve the many conflicts and merge them during the weekend.

Meanwhile, you probably want to take a look at the various changes that I've just pushed.

Thanks again!

lucasrla avatar Oct 21 '22 14:10 lucasrla

Your PR is now merged.

I left the highlighting parts out of the merge (given that I had followed a different path to support smart highlights). I also tweaked a bit of flags names / logic.

Thanks again!

lucasrla avatar Oct 23 '22 18:10 lucasrla

Okay, great, thanks for incorporating all this! I will do a pull into mine, and it should bring in all the changes.

folofjc avatar Oct 23 '22 19:10 folofjc