shortly icon indicating copy to clipboard operation
shortly copied to clipboard

Web App capability

Open gabrielvincent opened this issue 11 years ago • 2 comments

Hello, Luca!

I've just implemented a Web App capability to Shortly. I needed to include some meta tags on html's head and mess a bit with the CSS. I also included a new function to shortly.js so we could have a different behavior for mobile devices. It is possible to use it right on the mobile browser and, on iOS devices, add them to the home screen as a proper Web App.

I hope yo like it. Congrats for the great work

Cheers. screen shot 2013-05-12 at 23 11 52

gabrielvincent avatar May 13 '13 02:05 gabrielvincent

Thank's it looks good! Two things before I merge it in though:

  • Remove the .DS_Store files (that's my fault, it should be in the .gitignore, but I've got it in my global one).
  • The Javascript in lib is automatically generated from the CoffeeScript in src. You should update the CoffeeScript, then run make dev which will regenerate the Javascript, then commit both files.

lucaspiller avatar May 13 '13 07:05 lucaspiller

Just made the modifications you requested.

On 13/05/2013, at 04:12, Luca Spiller [email protected] wrote:

Thank's it looks good! Two things before I merge it in though:

Remove the .DS_Store files (that's my fault, it should be in the .gitignore, but I've got it in my global one). The Javascript in lib is automatically generated from the CoffeeScript in src. You should update the CoffeeScript, then run make dev which will regenerate the Javascript, then commit both files. — Reply to this email directly or view it on GitHub.

gabrielvincent avatar May 13 '13 11:05 gabrielvincent