Lucas Manuel Rodriguez

@xpkoala @sabrinabuckets To test/QA this you will have to manually download osquery 5.12.0 from https://github.com/osquery/osquery/releases/tag/5.12.0 and push it to your local TUF repository. Steps below: 1. Run `./tools/tuf/test/main.sh` as usual...

> I just ran into an issue, what if they save the `query.platform` as `"darwin,linux"` which is equivalent to `"linux,darwin"`? I'm assuming BE and FE should account for all equivalent...

> Should we create a bug ticket for this? I don't think so, what Rachel comments [here](https://github.com/fleetdm/fleet/issues/17018#issuecomment-1999860023) is related to fixing this bug/issue properly.

@xpkoala Added steps for QA.

@RachelElysia These are the backend changes for https://github.com/fleetdm/fleet/issues/11102 Will you address the frontend changes for it? (Feel free to push to this branch.)

While we're at it. (If the solution is to sign) Let's also sign `fleet-desktop.exe` (which is the other component in fleetd). And double check if osqueryd.exe as downloaded from Github...

Hi @kswagler-rh! Just for reference, #8924 is the issue where we introduced the behavior to not allow "Private IPs" in the "Public IP address".

We added this filtering [a while ago](https://github.com/fleetdm/fleet/pull/9900) to fix https://github.com/fleetdm/fleet/issues/9857: https://github.com/fleetdm/fleet/blob/2c383a060fab66105361f7ed88bc9969a02ec5e1/server/service/osquery_utils/queries.go#L376-L389 We may need to define what the "Public IP" field in Fleet is. Is it the IP of the...

> I also think we can remove the [Public IPs doc page](https://fleetdm.com/docs/deploy/public-ip) entirely to cut down on doc content. This is included in the "To fix" section. I believe it's...

Cool. I started working on the backend portion today.