openweathermap-ios icon indicating copy to clipboard operation
openweathermap-ios copied to clipboard

feat: Bookmark location model and manager

Open cassiosousa opened this issue 4 years ago • 9 comments

This pull request includes

  • It's adding testing module to project.
  • The structure of bookmark location model and manager.

Feat: #13

cassiosousa avatar Apr 24 '20 19:04 cassiosousa

Do you want partial reviews or do you prefer we wait until you say it is ready for review?

henrique-morbin-ifood avatar Apr 24 '20 19:04 henrique-morbin-ifood

Thank you Henrique, I don't have see your comment, but now is available to full review.

cassiosousa avatar Apr 24 '20 21:04 cassiosousa

Henrique,

I started to work at the view of bookmarkLocation. Those corners are giving work :), but it will be rewarding.

image image

cassiosousa avatar Apr 25 '20 05:04 cassiosousa

@cassiosousa give a better PR title please.

henrique-morbin-ifood avatar Apr 25 '20 22:04 henrique-morbin-ifood

@cassiosousa what did you mean with: Full backend to Add button ?

henrique-morbin-ifood avatar Apr 25 '20 22:04 henrique-morbin-ifood

@henrique-morbin-ifood

give a better PR title please. what did you mean with: Full backend to Add button ?

I updated the two things.

cassiosousa avatar Apr 26 '20 02:04 cassiosousa

Please, read this comment: https://github.com/lucasmontano/openweathermap-ios/pull/13#discussion_r416745061

henrique-morbin-ifood avatar Apr 28 '20 16:04 henrique-morbin-ifood

Please, read this comment: #13 (comment)

✅ @henrique-morbin-ifood , I go todo that change, it was suggest in the next PR. I also follow this guy hackingwithswift 🙂

cassiosousa avatar Apr 28 '20 16:04 cassiosousa

@lucasmontano LGTM

henrique-morbin-ifood avatar Apr 28 '20 20:04 henrique-morbin-ifood